-
-
Notifications
You must be signed in to change notification settings - Fork 27
Closed
Description
There are still problems with the server's stability, I. e. responding at all in some cases.
I noticed that sometimes Kotlin Scripting makes a lot of requests to the bindings sever about artifacts that are regular Maven packages, not action bindings. It happens when the list of dependencies contains some regular Maven packages as well. It leads to making lots of requests returning HTTP 404.
My hypothesis is that we're hitting some throttling on GitHub, or just these requests take some time and if there's a lot of them, the requests time out.
To do:
- distinguish failures when fetching a static resource from GitHub. Now, a failure to fetch one and a non-existing resource is interpreted the same way, so we swallow the failures. Use a Ktor Client
- add metrics on the number of calls to GitHub static resources
- add metrics on the number of calls to GitHub tags/branches
- optimize: early return 404 if the requested artifact's group ID consists of more than one segment - in GitHub, an owner consists of just one segment. Apply it in all routes that accept artifact path
- this is already done, but some groupId consists of just one segment for Maven packages. To cache the "not found" response, let me make this change: fix(server): support caching absence of version artifacts #2183
Metadata
Metadata
Assignees
Labels
No labels