Skip to content

blocking code  #44

@Libincn

Description

@Libincn

Hi, thanks for writing and releasing this application.
I am trying to look into your code in recent days and have learnt a lot.
I really like your coding style, clear and organized.

I have found one minor issue here about the blocking code as this app written in asynchronous way.
I notice you implement a class named bridge.
In WSHandler, the app calls bridge.open and it will call ssh.connect finally.
And ssh.connect is a blocking function. So it will block tornado's ioloop in the main thread.
I think it is not a good practice in asynchronous programming.

Lastly, thanks for sharing your code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions