Getting up from a bench placed at the very bottom of a looping map misplaces the player

[tsdko]

(2kki MAP1211 as of 0.127i patch 7)

The bench:

What you see:

What the other player sees:

[tsdko]

The cause appears to be an out-of-bounds jump. This fixes it for the players currently in the room (for non-negative coordinates at least):

--- a/src/multiplayer/game_multiplayer.cpp
+++ b/src/multiplayer/game_multiplayer.cpp
@@ -283,8 +283,8 @@ void Game_Multiplayer::InitConnection() {
 	connection.RegisterHandler<JumpPacket>("jmp", [this] (JumpPacket& p) {
 		if (players.find(p.id) == players.end()) return;
 		auto& player = players[p.id];
-		int x = Utils::Clamp(p.x, 0, Game_Map::GetTilesX() - 1);
-		int y = Utils::Clamp(p.y, 0, Game_Map::GetTilesY() - 1);
+		int x = Game_Map::LoopHorizontal() ? p.x : Utils::Clamp(p.x, 0, Game_Map::GetTilesX() - 1);
+		int y = Game_Map::LoopVertical() ? p.y : Utils::Clamp(p.y, 0, Game_Map::GetTilesY() - 1);
 		auto rc = player.ch->Jump(x, y);
 		if (rc) {
 			player.ch->SetMaxStopCount(player.ch->GetMaxStopCountForStep(player.ch->GetMoveFrequency()));

but it doesn't account for the saved position on the server (which does not know if the map loops or where it ends) so the player position is still wrong after reconnecting or reentering the room. Keeping the jmp coordinates within the map bounds would likely require a protocol change to account for jump direction. Alternative: allow negative coordinates on the server and make the client m handler wrap them around if the map is looping.