Use NaN-safe numpy functions in metric aggregations#312
Draft
Use NaN-safe numpy functions in metric aggregations#312
Conversation
- Replace numpy.sum with numpy.nansum - Replace numpy.max with numpy.nanmax - Replace numpy.min with numpy.nanmin - Replace numpy.average with numpy.nanmean - Replace numpy.percentile with numpy.nanpercentile - Replace numpy.std with numpy.nanstd - Replace numpy.var with numpy.nanvar - Add comprehensive test for NaN handling Co-authored-by: 4n4nd <22333506+4n4nd@users.noreply.github.com>
Co-authored-by: 4n4nd <22333506+4n4nd@users.noreply.github.com>
- Move math import to top of test file - Use np_array instead of query_values for percentile calculation for consistency Co-authored-by: 4n4nd <22333506+4n4nd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix handling of NaN values in metric aggregations
Use NaN-safe numpy functions in metric aggregations
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metric aggregations returned NaN when any data point contained NaN, making the aggregation functions unusable for real-world metrics with missing data.
Changes
Core aggregation logic: Replaced standard numpy functions with NaN-safe variants:
sum→nansum(treats NaN as 0)max/min→nanmax/nanmin(ignores NaN)average→nanmean(ignores NaN)percentile→nanpercentile(ignores NaN)std/var→nanstd/nanvar(ignores NaN)Consistency fix: Changed percentile calculation to use
np_arrayinstead ofquery_valueslist for alignment with other operationsExample
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.