-
Notifications
You must be signed in to change notification settings - Fork 456
Move integration tests to tests/integration and unit tests to tests/unit #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2111c89 to
9a05ddf
Compare
0da3c0f to
4058346
Compare
|
🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This pull request refactors the test directory structure by organizing tests into unit, integration, and integration/smoke directories. The changes are well-executed and improve the project's maintainability. The related paths in configuration, documentation, and scripts have been updated accordingly.
🔍 General Feedback
- The restructuring is a positive step towards a more organized and scalable test suite.
- The use of
pytest.mark.integration_testis a good practice for separating test types. - One minor suggestion was made to use
os.path.joinfor path construction to improve cross-platform compatibility.
Overall, this is a solid contribution that improves the project's structure.
hengtaoguo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactor!
4058346 to
5d66b49
Compare
Description
tests/integrationtests/unittests/integration/smokeTests
CI tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.