Skip to content

Conversation

@aireenmei
Copy link
Collaborator

@aireenmei aireenmei commented Jan 15, 2026

Description

Original author @eitanporat in #2726

Revise according to the original PR comments:

  • rename flags for consistency and clean up usage
  • make AudioEncoder an NNX module
  • remove SinusoidsPositionEmbedding, replaced with expanded existing PositionalEmbedding module
  • remove Qwen3OmniAudioModel in qwen3.py since we use the AudioEncoder class in decoder.py instead
  • add precision related flags

Tests

tests/check_qwen3_omni_audio_vs_reference.py all pass

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Jan 15, 2026

@hengtaoguo
Copy link
Collaborator

Thank you for the great work!

Copy link
Collaborator

@NicoGrande NicoGrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aireenmei aireenmei force-pushed the aireen/qwen-audio branch 3 times, most recently from 3525828 to 8861cc2 Compare January 22, 2026 19:08
Co-authored-by: Eitan Porat <eporat@lightricks.com>
@copybara-service copybara-service bot merged commit 56bcd76 into main Jan 23, 2026
25 checks passed
@copybara-service copybara-service bot deleted the aireen/qwen-audio branch January 23, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants