Avoid change user global kube config#1024
Open
wdhongtw wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Open
Avoid change user global kube config#1024wdhongtw wants to merge 1 commit intoAI-Hypercomputer:mainfrom
wdhongtw wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
wdhongtw
requested review from
FIoannides,
SikaGrr,
jamOne-,
scaliby and
stony-tark
as code owners
wdhongtw
force-pushed
the
kube-sandbox
branch
2 times, most recently
from
e167277 to
f3a902e
Compare
Member
|
Hey @wdhongtw! Thanks for the change. |
Author
|
Turn back to draft to address the comment above. 🙂 |
Try creating sandbox kube config for xpk tool, avoiding confusing bug and allowing parallel invocation of xpk tools in same environment. To preserve original behavior, this change is activated through an optional flag and default to false. Signed-off-by: Weida Hong <wdhongtw@google.com>
wdhongtw
force-pushed
the
kube-sandbox
branch
from
f3a902e to
315b3eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try creating sandbox kube config for xpk tool, avoiding confusing bug and allowing parallel invocation of xpk tools in same environment.
To preserve original behavior, this change is activated through an optional flag and default to false.
Issue
xpk tool running in background will suddenly interrupt user's foreground work once the cluster healthy check is passed.
Because xpk will try to get a credential and update user's global kube config and activate it.
Testing
Manually tested.