ProPhotoRGB builtin transforms#2215
ProPhotoRGB builtin transforms#2215ssh4net wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Add ProPhotoRGB (ROMM RGB) as a set of builtin transforms for color space conversions between ProPhotoRGB and ACES2065-1, including both native gamma 1.8 and sRGB gamma variants. Updates documentation: usage and available styles, registers the transforms in the registry. Adds comprehensive unit tests for registration, gamma curves, round-trip, and variant support. Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Thanks for the contribution Vlad.
Technically, there should be a version check added to ensure these are not used with configs for earlier versions of the library. But I will add that for you after the TSC decides what release to assign this to.
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Thanks for the updates Vlad. Here are a few more requests, below.
Regarding the sRGB ProPhoto, it does not need a special LUT, so it is easy for people to add to configs, if they want. I will confirm at the next TSC meeting, but I don't think we should make this a built-in.
src/OpenColorIO/transforms/builtins/BuiltinTransformRegistry.cpp
Outdated
Show resolved
Hide resolved
tests/cpu/transforms/builtins/BuiltinTransformRegistry_tests.cpp
Outdated
Show resolved
Hide resolved
• ProPhotoRGB.cpp to remove unused linear-to-encoded LUT generation and updated the color space conversion to use build_conversion_matrix_to_XYZ_D65. • test cases in BuiltinTransform_tests.cpp and BuiltinTransformRegistry_tests.cpp. Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
|
@doug-walker i can't get what a problem with CLs. I have tested code builds in MSVC on windows and in clang-20 on Ubuntu. |
2 participants
Add ProPhotoRGB (ROMM RGB) as a set of builtin transforms for color space conversions between ProPhotoRGB and ACES2065-1, including both native gamma 1.8 and sRGB gamma variants. Updates documentation: usage and available styles, registers the transforms in the registry. Adds comprehensive unit tests for registration, gamma curves, round-trip, and variant support.