Refactor unpaid function for clarity and date fix#5
Open
CaptainFulminyx wants to merge 1 commit intoAcode-Foundation:mainfrom
Open
Refactor unpaid function for clarity and date fix#5CaptainFulminyx wants to merge 1 commit intoAcode-Foundation:mainfrom
CaptainFulminyx wants to merge 1 commit intoAcode-Foundation:mainfrom
Conversation
Refactor unpaid function to improve readability and adjust date handling.
Author
|
Please check the PR |
Member
@deadlyjack Will be checking it, I've informed him. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous function logic was generating end of the month despite current date which may be Future time and may be confusing to users. The current function just makes the unpaid earnings "To date" "current day date"