Fix return type annotation bug #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/823 |
erikgaas
commented
Jan 16, 2026
| if not resp: resp='' | ||
| if hasattr(resp, '__response__'): resp = resp.__response__(req) | ||
| if cls in (Any,FT): cls=empty | ||
| if not (isinstance(cls, type) and issubclass(cls, Response)): cls=empty |
Contributor
Author
There was a problem hiding this comment.
The Any, and FT checks are covered in isisntance type check. the type checking is required or else issubclass Response will throw an error.
Contributor
Author
|
I could also see this however as suppressing errors if someone expects some type of behavior. so we could throw an error? but this seems along the lines of what was intended for now |
Contributor
|
Good idea! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814.
Previously, return type annotations like
-> Titledwould cause aTypeError: 'tuple' object is not callablebecause FastHTML tried to call the annotation as a constructor.The fix: only use the return type annotation for wrapping when it's actually a
Responsesubclass. This makes sense because the wrapping code passesstatus_codeas a keyword argument, which only Response subclasses accept.