Meta description field fix #2794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This change avoids strings.TrimSpace because CI currently runs Hugo v0.130.0, which errors when trimming an interface{} param. Local builds use a newer Hugo and work either way. |
Contributor
|
Nice catch and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where tags were emitted with only whitespace due to incomplete whitespace trimming in the head template.
The template now fully normalizes and trims the description front matter value and only emits the meta tag when a non-empty value remains.
Testing: Verified locally by rebuilding with Hugo and inspecting generated HTML. Pages with a description field now emit a correct meta description, and no whitespace-only tags are generated.