Skip to content

Conversation

@KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Feb 1, 2026

close #3017

Summary by CodeRabbit

  • Chores

    • Upgraded Node.js runtime from v22 to v24 across CI, container, and contributor guidance.
    • Updated minimum Node.js engine requirement to 24.x.
    • Adjusted workspace dependency handling to optimize build behavior.
    • Removed legacy nodejs22 runtime references.
  • Documentation

    • Added a comprehensive Node.js v22→v24 upgrade plan with verification checklist and rollout notes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

Warning

Rate limit exceeded

@KATO-Hiro has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

This PR upgrades Node.js references from v22 to v24 across CI, Docker, docs, package metadata, pnpm workspace, and Svelte adapter; and adds a detailed Japanese upgrade plan and verification checklist document.

Changes

Cohort / File(s) Summary
CI
.github/workflows/ci.yml
Removed Node 22 from matrix and set setup-node steps to node-version: 24.
Container / Devcontainer
Dockerfile
Bumped ARG NODE_VERSION from 22 to 24, updating the base image tag.
Project runtime & meta
package.json, CONTRIBUTING.md
Changed engines.node to 24.x; updated CONTRIBUTING guidance from v22 to v24.
Package manager workspace
pnpm-workspace.yaml
Added onlyBuiltDependencies list (e.g., @prisma/client, esbuild, prisma, puppeteer, lefthook).
Framework config
svelte.config.js
Removed runtime: 'nodejs22.x' from adapter configuration.
Documentation / Plan
docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md
Added comprehensive Japanese upgrade plan, checklist, phase statuses, and verification notes for v22→v24 migration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through branches, files in paw,
Swapped twenty-two for twenty-four, hurrah!
Docs and Docker, CI all sing,
A tidy bump, a joyous spring,
Small hop, big change — I nibble the log 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: bumping Node.js from v22.x to v24.x, which is the primary objective of the pull request.
Linked Issues check ✅ Passed All code changes align with the linked issue #3017 requirements: Node.js upgraded from v22.x to v24.x across CI workflow, Dockerfile, CONTRIBUTING.md, package.json, and svelte.config.js as part of a complete runtime upgrade.
Out of Scope Changes check ✅ Passed All changes are directly related to the Node.js v24 upgrade objective: CI workflow, Dockerfile, CONTRIBUTING.md, package.json, pnpm-workspace.yaml, svelte.config.js, and upgrade documentation are all necessary for the migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch #3017

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md`:
- Line 10: Update the top-level status line currently reading "**ステータス**: 🔄
実装予定" so it matches the completed state shown later in the document (change to a
completed label such as "完了" or "完了済み" and corresponding emoji), and ensure the
phase/status badges in the phases summary section are consistent with that
change; specifically locate the line containing "**ステータス**: 🔄 実装予定" and the
phases summary block where all phases are marked completed and make their
labels/emoji consistent so the document no longer shows a planned status at the
top while the rest are completed.
- Around line 16-23: The TOC entry for "pnpm v10 対応" has a mismatched fragment;
update the link target in the TOC item referencing "pnpm v10 対応" so it exactly
matches the generated heading slug for the heading "pnpm v10 対応" (adjust hyphens
or percent-encoding as your Markdown renderer produces), i.e., edit the TOC list
item that links the "pnpm v10 対応" heading so its fragment equals the actual
heading anchor.

In `@svelte.config.js`:
- Around line 14-18: The svelte.config.js adapter block uses an unsupported
runtime value; update the adapter: adapter({ ... }) configuration by removing or
replacing runtime: 'nodejs24.x' with a supported option ('edge', 'nodejs20.x',
or 'nodejs22.x') or drop the runtime property entirely, and instead set Node 24
via Vercel Project Settings or by adding "engines": { "node": "24.x" } to
package.json; adjust the adapter configuration near the adapter(...) call and
ensure no other code relies on the deprecated runtime property.
🧹 Nitpick comments (1)
package.json (1)

90-92: Tighten engines.node to match the Node 24 CI baseline.
CI now tests only Node 24 (matrix at line 32), and deployment targets nodejs24.x, while engines.node still permits Node 22. Updating to >=24.0.0 prevents developers from unknowingly using untested versions locally.

🔧 Proposed adjustment
 "engines": {
-  "node": ">=22.0.0"
+  "node": ">=24.0.0"
 }

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md`:
- Around line 385-386: Update the paragraph to remove the claim that
svelte.config.js has a `nodejs24.x` setting and instead state that the `runtime`
option was removed from svelte.config.js; explain that Node v24 support is
ensured via package.json "engines" and the Vercel Dashboard deployment/runtime
setting, and then say that after this plan completes production deploy is
possible. Reference the `svelte.config.js` runtime removal, `package.json`
engines field, and Vercel Dashboard/runtime setting in the updated text.
- Line 268: Update the checklist entry that currently reads "svelte.config.js:
`nodejs22.x` → `nodejs24.x`" to reflect that the `runtime` option was removed
rather than changed; edit the text associated with svelte.config.js to state
that the `runtime` option was removed (and note that `nodejs24.x` is invalid for
adapter-vercel v6.3.1) so it aligns with the explanation in the document (see
the svelte.config.js section that describes removal of the runtime option).

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md`:
- Around line 161-177: Consolidate the contradictory package.json "engines.node"
entries into a single accurate requirement by keeping only the fixed "24.x"
value and removing the earlier ">=22.0.0" block; update the surrounding section
heading so there is a single "package.json - engines フィールド" entry (rename the
later "### 5." to "### 4." if needed) and ensure the JSON example and its
comment reflect "node": "24.x" consistently.

Copy link
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 3642cfa into staging Feb 1, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3017 branch February 1, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dep] Node.js v24 にアップグレードしましょう

2 participants