-
-
Notifications
You must be signed in to change notification settings - Fork 10
build: Bump Node.js from v22.x to v24.x (#3017) #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis PR upgrades Node.js references from v22 to v24 across CI, Docker, docs, package metadata, pnpm workspace, and Svelte adapter; and adds a detailed Japanese upgrade plan and verification checklist document. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md`:
- Line 10: Update the top-level status line currently reading "**ステータス**: 🔄
実装予定" so it matches the completed state shown later in the document (change to a
completed label such as "完了" or "完了済み" and corresponding emoji), and ensure the
phase/status badges in the phases summary section are consistent with that
change; specifically locate the line containing "**ステータス**: 🔄 実装予定" and the
phases summary block where all phases are marked completed and make their
labels/emoji consistent so the document no longer shows a planned status at the
top while the rest are completed.
- Around line 16-23: The TOC entry for "pnpm v10 対応" has a mismatched fragment;
update the link target in the TOC item referencing "pnpm v10 対応" so it exactly
matches the generated heading slug for the heading "pnpm v10 対応" (adjust hyphens
or percent-encoding as your Markdown renderer produces), i.e., edit the TOC list
item that links the "pnpm v10 対応" heading so its fragment equals the actual
heading anchor.
In `@svelte.config.js`:
- Around line 14-18: The svelte.config.js adapter block uses an unsupported
runtime value; update the adapter: adapter({ ... }) configuration by removing or
replacing runtime: 'nodejs24.x' with a supported option ('edge', 'nodejs20.x',
or 'nodejs22.x') or drop the runtime property entirely, and instead set Node 24
via Vercel Project Settings or by adding "engines": { "node": "24.x" } to
package.json; adjust the adapter configuration near the adapter(...) call and
ensure no other code relies on the deprecated runtime property.
🧹 Nitpick comments (1)
package.json (1)
90-92: Tightenengines.nodeto match the Node 24 CI baseline.
CI now tests only Node 24 (matrix at line 32), and deployment targets nodejs24.x, whileengines.nodestill permits Node 22. Updating to>=24.0.0prevents developers from unknowingly using untested versions locally.🔧 Proposed adjustment
"engines": { - "node": ">=22.0.0" + "node": ">=24.0.0" }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md`:
- Around line 385-386: Update the paragraph to remove the claim that
svelte.config.js has a `nodejs24.x` setting and instead state that the `runtime`
option was removed from svelte.config.js; explain that Node v24 support is
ensured via package.json "engines" and the Vercel Dashboard deployment/runtime
setting, and then say that after this plan completes production deploy is
possible. Reference the `svelte.config.js` runtime removal, `package.json`
engines field, and Vercel Dashboard/runtime setting in the updated text.
- Line 268: Update the checklist entry that currently reads "svelte.config.js:
`nodejs22.x` → `nodejs24.x`" to reflect that the `runtime` option was removed
rather than changed; edit the text associated with svelte.config.js to state
that the `runtime` option was removed (and note that `nodejs24.x` is invalid for
adapter-vercel v6.3.1) so it aligns with the explanation in the document (see
the svelte.config.js section that describes removal of the runtime option).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-01-27/bump-nodejs-from-v22-to-v24/plan.md`:
- Around line 161-177: Consolidate the contradictory package.json "engines.node"
entries into a single accurate requirement by keeping only the fixed "24.x"
value and removing the earlier ">=22.0.0" block; update the surrounding section
heading so there is a single "package.json - engines フィールド" entry (rename the
later "### 5." to "### 4." if needed) and ensure the JSON example and its
comment reflect "node": "24.x" consistently.
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #3017
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.