Merged
Conversation
rickyrombo
approved these changes
Feb 12, 2026
api/v1_users_developer_apps.go
Outdated
|
|
||
| // requirePlansAppAuth validates Bearer token and checks that the plans app has a grant from the user. | ||
| // Must run after requireUserIdMiddleware. | ||
| func (app *ApiServer) requirePlansAppAuth(c *fiber.Ctx) error { |
Contributor
There was a problem hiding this comment.
this feels like it should belong somewhere else?
config/config.go
Outdated
| RewardCodeAuthorizedKeys []string | ||
| LaunchpadDeterministicSecret string | ||
| UnsplashKeys []string | ||
| AudiusApiSecret string |
Contributor
There was a problem hiding this comment.
maybe some context of where this is used/why it's here? It may not be obvious this is just for the plans app and not being used broadly for the api
Member
Author
There was a problem hiding this comment.
I think this is reasonable to have across the API, other things could use it. I'll add a comment though.
It's so that you can authorize api.audius.co to do something for you
Contributor
There was a problem hiding this comment.
perhaps... i just don't want there to be confusion about "oh i have an api key, it probably has access to do stuff on behalf of users" or whatever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Play with it here:
https://weathered-field-271e.audius.workers.dev/
It's a bit messy, will do some passes with cursor to clean up after it goes out