fix: skip update repo if install has opt to define source #7504
+368
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fseldow
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
fseldow
changed the title
fseldow
changed the title
lilypan26
reviewed
Dec 23, 2025
lilypan26
reviewed
Dec 23, 2025
parts/linux/cloud-init/artifacts/mariner/cse_helpers_mariner.sh
Outdated
Show resolved
Hide resolved
lilypan26
reviewed
Dec 26, 2025
lilypan26
reviewed
Jan 7, 2026
| # Install the package from the local repository | ||
| echo "Installing ${tool_name} from local repository" | ||
| if ! dnf_install 30 1 600 ${tool_name} --disablerepo='*' --enablerepo="${repo_name}"; then | ||
| if ! dnf_install 4 1 120 ${tool_name} --disablerepo='*' --enablerepo="${repo_name}"; then |
Contributor
There was a problem hiding this comment.
why are we adjusting the retry and timeout values for the install?
Contributor
Author
There was a problem hiding this comment.
600s means 10min, which already exceed the cse timeout. (though it seems timeout is not implement in dnf_install)
if the cse timeout, the extension error msg will only left csetimeout without correct exit code or helpful log.
But considering the timeout is not working for now, i will revert this retry and timeout values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
we observed ni cluster with for azure linux node pool has latency issue for vmss creation. The cse will stuck at 'dnf makecache --disablerepo='*' --enablerepo="${repo_name}"' It will stuck over 10 minutes and finally caused the cse exit with timeout. However, the next instance or ssh into failed node both can work. Thus i make this pr to add timeout option for 'dnf makecache' and 'apt update'.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: