-
Notifications
You must be signed in to change notification settings - Fork 241
feat: add ServiceAccountImagePullProfile for identity-binding-based image pull #7596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This PR's logic LGTM. But I don't quiet understand what is step 2 "RP integration and configuration flow". Agentbaker won't rely on anything from AKS RP, I think you could make all changes in the same PR and add E2E for it? Here is an example PR: #7059 . |
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
1a47af0 to
67be361
Compare
| type SecurityProfile struct { | ||
| PrivateEgress *PrivateEgress `json:"privateEgress,omitempty"` | ||
| PrivateEgress *PrivateEgress `json:"privateEgress,omitempty"` | ||
| ServiceAccountImagePullProfile *ServiceAccountImagePullProfile `json:"serviceAccountImagePullProfile,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very sure, but this profile belongs to ContainerService.Properties, it's not very common(?) to directly edit this struct, we typically append NodeBootstrappingConfiguration for feature implementation. Node sig reviewers may have more insight into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the comment here mentioning that Properties stands for the AKS cluster definition. Therefore, I thought that AKS-related settings ought to be placed in properties?
| - kubernetes.azure.com/acr-client-id" | ||
| IB_ARGS=" | ||
| - --ib-sni-name=${IDENTITY_BINDINGS_LOCAL_AUTHORITY_SNI} | ||
| - --ib-default-client-id=${SERVICE_ACCOUNT_IMAGE_PULL_DEFAULT_CLIENT_ID} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new parameter, requires specific version credential provider binary. We need to ensure new version credential provider binary is present when these parameters are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I also have a question, for old VHDs which does not have new credential provider binary, this feature shall not be available. Where can we verify and guard this? CC @cameronmeissner do you have any insight into this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial idea is to have $SERVICE_ACCOUNT_IMAGE_PULL_ENABLED completely indicate credential provider readiness by:
- Allowing this feature to be enabled only for k8s version >= v1.35 (as specified in PRD) and enforcing the version verification in RP
- Ensuring that the credential provider released for 1.35 supports this flag
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for service-account-based image pull authentication (aka Identity Binding) from Azure Container Registry (ACR), implementing KEP-4412 projected service account tokens for kubelet image credential providers.
Changes
Data Model
Added
ServiceAccountImagePullProfiletoSecurityProfilewith fields:Enabled: Enable/disable service account-based image pullDefaultClientID: Default managed identity client IDDefaultTenantID: Default managed identity tenant IDLocalAuthoritySNI: SNI endpoint for Identity Bindings Local AuthorityAdded getter methods to
SecurityProfilefor null-safe access.Implementation Paths
1. Legacy CSE (Template-based)
pkg/agent/variables.go: Template variables for CSE scripts (using the naming conventionserviceAccountImagePull...)parts/linux/cloud-init/artifacts/cse_cmd.sh: Environment variable declarations (e.g.,SERVICE_ACCOUNT_IMAGE_PULL_ENABLED,SERVICE_ACCOUNT_IMAGE_PULL_DEFAULT_CLIENT_ID)parts/linux/cloud-init/artifacts/cse_config.sh: Credential provider config generation2. AKSNodeConfig (Proto-based)
aks-node-controller/proto/aksnodeconfig/v1/security_profile.proto: Proto definitions (ServiceAccountImagePullProfile)aks-node-controller/parser/parser.go: Environment variable generationaks-node-controller/parser/helper.go: Null-safe helper functionsBoth paths converge at
cse_config.shto generate/var/lib/kubelet/credential-provider-config.yamlwith identity binding arguments (--ib-default-client-id,--ib-default-tenant-id,--ib-sni-name) and token attributes.Testing
variables_test.go,datamodel/types_test.go, andparser/helper_test.goto reflect the new naming convention.pkg/agent/testdata(117 files) to reflect the newSERVICE_ACCOUNT_IMAGE_PULL_environment variables.All tests validate that the credential provider config file contains the correct identity binding configuration.
Cluster Support
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Dual implementation approach (legacy CSE + modern AKSNodeConfig) for backward compatibility. Both paths are fully tested and generate identical credential provider configuration. The renaming from
ImagePullIdentitytoServiceAccountImagePullensures consistency with the upstream feature name.Release note: