Skip to content

validate doc diffs #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iscai-msft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

validate doc diffs #3314

iscai-msft wants to merge 1 commit into from

Conversation

@iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Jan 27, 2026

iscai-msft
iscai-msft commented Jan 27, 2026
View reviewed changes
...-generator-core-access/specs/azure/clientgenerator/core/access/aio/operations/_operations.py
async def _operation(self, *, name: str, **kwargs: Any) -> _models._models.OuterModel:
"""Expected query parameter: name="Madge"
Expected response body:
"""Expected query parameter: name="Madge" Expected response body:
Copy link
Contributor Author

@iscai-msft iscai-msft Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no . in the specs doc, we don't generate it on a new line. We're not sure of user intent so we don't indent, which helps us out in a lot of other ways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dargilco dargilco dargilco approved these changes

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iscai-msft @dargilco