-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[RDBMS] az postgres flexible-server create: Change database name field to default to None
#32587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[RDBMS] az postgres flexible-server create: Change database name field to default to None
#32587
Conversation
…d to default to None
️✔️AzureCLI-FullTest
|
|
Hi @mattboentoro, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
az postgres flexible-server create: Change database name field to default to None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the az postgres flexible-server create command where the database_name parameter was referencing an undefined argument type database_name_create_arg_type, which would cause a runtime error.
- Corrects the
database_nameparameter to use the existingdatabase_name_arg_type - Explicitly sets
default=Nonefor clarity, as the parameter is optional
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@evelyn-ys do you mind reviewing this PR? |
|
Please define and put back for create “database_name_create_arg_type” to use of db renaming for clusters. This will be different than normal db name property used in db commands. Hav description state use for clusters. |
|
[RDBMS] az postgres flexible-server create: Change database name field to default to None -> {RDBMS} az postgres flexible-server create: BUG FIX Define database name argument Not public facing change |
|
Please fix CI issues |
|
@yonzhan do you mind reviewing this PR? |
Related command
az postgres flexible-server create
Description
Change database name field to default to None
Testing Guide
Manual testing
History Notes
[RDBMS]
az postgres flexible-server create: Change database name field to default to NoneThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.