{MySQL} az mysql flexible-server restore: Support different subscription and resource group
#32620
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for cross-subscription and cross-resource-group restore, geo-restore, and replica creation operations for MySQL flexible servers. This enables users to restore or replicate servers to different subscriptions and resource groups by providing a full resource ID instead of just the server name.
Key Changes
- Added
get_mysql_flexible_management_client_by_subfunction to create MySQL management clients with a specific subscription ID - Updated
flexible_server_restore,flexible_server_georestore, andflexible_replica_createto use the new client factory when working with source servers in different subscriptions - Added help documentation with examples showing how to use resource IDs for cross-subscription/cross-resource-group operations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/mysql/_client_factory.py | Added get_mysql_flexible_management_client_by_sub function to support creating MySQL management clients with a specified subscription ID |
| src/azure-cli/azure/cli/command_modules/mysql/custom.py | Updated restore, geo-restore, and replica create functions to fetch source server using subscription-specific client |
| src/azure-cli/azure/cli/command_modules/mysql/_help.py | Added documentation examples demonstrating cross-subscription and cross-resource-group restore/replica operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Here --resource-group is for the target server's resource group, and --source-server must be passed as resource ID. | ||
| text: > | ||
| az mysql flexible-server restore --resource-group testGroup --name testserverNew \\ | ||
| --source-server /subscriptions/{testSubscription}/resourceGroups/{sourceResourceGroup}/providers/Microsoft.DBforMySQL/flexibleServers/{sourceServerName} |
There was a problem hiding this comment.
The placeholder name should be consistent across all examples. Use {sourceSubscriptionId} instead of {testSubscription} to match the other examples in lines 410, 438, and 685.
Suggested change
| --source-server /subscriptions/{testSubscription}/resourceGroups/{sourceResourceGroup}/providers/Microsoft.DBforMySQL/flexibleServers/{sourceServerName} | |
| --source-server /subscriptions/{sourceSubscriptionId}/resourceGroups/{sourceResourceGroup}/providers/Microsoft.DBforMySQL/flexibleServers/{sourceServerName} |
| Here --resource-group is for the read replica's resource group, and --source-server must be passed as resource ID. | ||
| This resource ID can be in a subscription different than the subscription used for az account set. | ||
| text: > | ||
| az mysql flexible-server replica create --replica-name testReplicaServer -g newTestGroup \ |
There was a problem hiding this comment.
Use double backslash \\ for line continuation to be consistent with other examples in the file (lines 402, 409, 437). Single backslash \ should be replaced with \\.
Suggested change
| az mysql flexible-server replica create --replica-name testReplicaServer -g newTestGroup \ | |
| az mysql flexible-server replica create --replica-name testReplicaServer -g newTestGroup \\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server restore
az mysql flexible-server geo-restore
az mysql flexible-server replica create
Description
Support different subscription and resource group in restore, geo-restore and replica creation.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.