Howie/sample recording 6 #44533
Open
Howie/sample recording 6 #44533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howieleung
requested review from
dargilco,
glharper,
kingernupur,
nick863,
trangevi and
trrwilson
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the sample test infrastructure for the Azure AI Projects Python SDK in preparation for moving test executor classes to dev tools. The changes separate concerns between helper functions, executor classes, and documentation.
Key changes:
- Extracted test executor classes (
SyncSampleExecutor,AsyncSampleExecutor) intosample_executor.py - Created
test_samples_helpers.pyfor helper functions not destined for dev tools - Separated LLM validation into dedicated methods (
validate_print_calls_by_llm,validate_print_calls_by_llm_async) - Added
AdditionalTestsWithEnvironmentVariablesdecorator for recording samples with optional environment variables - Added comprehensive README documentation with usage examples
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/tests/samples/test_samples_helpers.py | New file containing shared helper functions including LLM validation instructions and environment variable mapping |
| sdk/ai/azure-ai-projects/tests/samples/sample_executor.py | New file with executor classes and helper functions, including the new decorator for optional environment variables |
| sdk/ai/azure-ai-projects/tests/samples/sample_executor_helpers.py | Deleted file - content moved to sample_executor.py and test_samples_helpers.py |
| sdk/ai/azure-ai-projects/tests/samples/test_samples.py | Updated imports and separated LLM validation into a separate method call |
| sdk/ai/azure-ai-projects/tests/samples/test_samples_async.py | Updated imports, separated LLM validation, and added decorator usage for optional env vars |
| sdk/ai/azure-ai-projects/tests/samples/README.md | New comprehensive documentation for using the sample testing infrastructure |
howieleung
force-pushed
the
howie/sample-recording-6
branch
from
224a33c to
b0117d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refractor code for Python SDK team to move sample test feature to dev tools:
New stuff: