[AutoPR azure-mgmt-servicefabricmanagedclusters]-generated-from-SDK Generation - Python-5919239#45333
Open
azure-sdk wants to merge 1 commit intoAzure:mainfrom
Conversation
…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2026-02-01, SDK Release Type: stable, and CommitSHA: '57a2504930224552a409d9435d523e631a6c93e2' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5919239 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This is an auto-generated pull request that updates the Azure Service Fabric Managed Clusters Management SDK from version 2.1.0b5 (beta, API version 2025-10-01-preview) to version 3.0.0 (stable, API version 2026-02-01). The changes are generated from TypeSpec definitions in the Azure REST API specifications repository.
Changes:
- Promotes the SDK from beta to stable status with a major version bump to 3.0.0
- Updates the API version from 2025-10-01-preview to 2026-02-01
- Removes fault simulation functionality (models, enums, and operations)
- Changes timeout field types from
datetime.timedeltato ISO 8601 formatted strings - Adds new properties:
skip_managed_nsg_assignmentandenable_resilient_ephemeral_os_disk - Improves security by replacing
eval()with explicit type checking in serialization utilities - Updates code generation to use newer emitter version (0.60.1 from 0.53.1)
Reviewed changes
Copilot reviewed 100 out of 102 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updates commit SHA to point to new API specification version |
| pyproject.toml | Changes Development Status from Beta to Production/Stable and sets is_stable = true |
| _version.py | Bumps version from 2.1.0b5 to 3.0.0 |
| _configuration.py, aio/_configuration.py | Updates default API version from 2025-10-01-preview to 2026-02-01 |
| _client.py, aio/_client.py | Updates API version documentation |
| _metadata.json | Updates API version, commit SHA, and emitter version |
| models/_models.py | Removes fault simulation models; changes timeout types from timedelta to str; adds new properties |
| models/_enums.py | Removes fault simulation enums; updates documentation formatting |
| models/init.py | Removes fault simulation model and enum imports |
| _utils/serialization.py | Replaces eval() with explicit type checking for security improvement |
| _utils/model_base.py | Adds array encoding support; improves deserialization caching; broadens exception handling in failsafe methods |
| apiview-properties.json | Removes fault simulation API mappings |
| generated_tests/*.py | Removes fault simulation test methods; adds new test parameters; changes timeout test values from timedelta to strings |
| generated_samples/*.py | Removes fault simulation sample files; updates API version comments; adds new sample parameters |
| CHANGELOG.md | Documents version 3.0.0 release with features and breaking changes |
| - Deleted or renamed model `UpgradeMode` | ||
| - Deleted or renamed method `ApplicationsOperations.update` | ||
| - Deleted or renamed method `ManagedClustersOperations.update` | ||
| - Deleted or renamed method `NodeTypesOperations.update` |
There was a problem hiding this comment.
The CHANGELOG is missing several breaking changes related to the removal of fault simulation functionality. The following items were removed but are not documented in the Breaking Changes section:
- Deleted model
FaultSimulation - Deleted model
FaultSimulationConstraints - Deleted model
FaultSimulationContent - Deleted model
FaultSimulationContentWrapper - Deleted model
FaultSimulationDetails - Deleted model
FaultSimulationIdContent - Deleted model
NodeTypeFaultSimulation - Deleted model
ZoneFaultSimulationContent - Deleted enum
FaultKind - Deleted enum
FaultSimulationStatus - Deleted enum
SfmcOperationStatus - Deleted method
ManagedClustersOperations.get_fault_simulation - Deleted method
ManagedClustersOperations.list_fault_simulation - Deleted method
ManagedClustersOperations.begin_start_fault_simulation - Deleted method
ManagedClustersOperations.begin_stop_fault_simulation - Deleted method
NodeTypesOperations.begin_start_fault_simulation - Deleted method
NodeTypesOperations.begin_stop_fault_simulation - Deleted method
NodeTypesOperations.get_fault_simulation - Deleted method
NodeTypesOperations.list_fault_simulation
These removals represent significant breaking changes that should be documented for users upgrading to this version.
Suggested change
| - Deleted or renamed method `NodeTypesOperations.update` | |
| - Deleted or renamed method `NodeTypesOperations.update` | |
| - Deleted model `FaultSimulation` | |
| - Deleted model `FaultSimulationConstraints` | |
| - Deleted model `FaultSimulationContent` | |
| - Deleted model `FaultSimulationContentWrapper` | |
| - Deleted model `FaultSimulationDetails` | |
| - Deleted model `FaultSimulationIdContent` | |
| - Deleted model `NodeTypeFaultSimulation` | |
| - Deleted model `ZoneFaultSimulationContent` | |
| - Deleted enum `FaultKind` | |
| - Deleted enum `FaultSimulationStatus` | |
| - Deleted enum `SfmcOperationStatus` | |
| - Deleted method `ManagedClustersOperations.get_fault_simulation` | |
| - Deleted method `ManagedClustersOperations.list_fault_simulation` | |
| - Deleted method `ManagedClustersOperations.begin_start_fault_simulation` | |
| - Deleted method `ManagedClustersOperations.begin_stop_fault_simulation` | |
| - Deleted method `NodeTypesOperations.begin_start_fault_simulation` | |
| - Deleted method `NodeTypesOperations.begin_stop_fault_simulation` | |
| - Deleted method `NodeTypesOperations.get_fault_simulation` | |
| - Deleted method `NodeTypesOperations.list_fault_simulation` |
Comment on lines
+5
to
+46
| ### Features Added | ||
|
|
||
| - Model `ServiceFabricManagedClustersManagementClient` added parameter `cloud_setting` in method `__init__` | ||
| - Client `ServiceFabricManagedClustersManagementClient` added method `send_request` | ||
| - Enum `DiskType` added member `PREMIUM_V2_LRS` | ||
| - Enum `DiskType` added member `PREMIUM_ZRS` | ||
| - Enum `DiskType` added member `STANDARD_SSD_ZRS` | ||
| - Model `ManagedClusterCodeVersionResult` added property `properties` | ||
| - Enum `SecurityType` added member `CONFIDENTIAL_VM` | ||
| - Model `ServiceEndpoint` added property `network_identifier` | ||
| - Added model `ApplicationFetchHealthRequest` | ||
| - Added enum `AutoGeneratedDomainNameLabelScope` | ||
| - Added enum `CreatedByType` | ||
| - Added model `ErrorAdditionalInfo` | ||
| - Added model `ErrorDetail` | ||
| - Added model `ErrorResponse` | ||
| - Added enum `HealthFilter` | ||
| - Added model `IPConfigurationPublicIPAddressConfiguration` | ||
| - Added model `ManagedClusterVersionDetails` | ||
| - Added model `RestartDeployedCodePackageRequest` | ||
| - Added enum `RestartKind` | ||
| - Added model `RestartReplicaRequest` | ||
| - Added model `RuntimeApplicationHealthPolicy` | ||
| - Added enum `RuntimeFailureAction` | ||
| - Added enum `RuntimeRollingUpgradeMode` | ||
| - Added model `RuntimeRollingUpgradeUpdateMonitoringPolicy` | ||
| - Added model `RuntimeServiceTypeHealthPolicy` | ||
| - Added model `RuntimeUpdateApplicationUpgradeParameters` | ||
| - Added enum `RuntimeUpgradeKind` | ||
| - Added enum `SecurityEncryptionType` | ||
| - Added model `TrackedResource` | ||
| - Added model `VmApplication` | ||
| - Model `ApplicationsOperations` added method `begin_fetch_health` | ||
| - Model `ApplicationsOperations` added method `begin_restart_deployed_code_package` | ||
| - Model `ApplicationsOperations` added method `begin_update` | ||
| - Model `ApplicationsOperations` added method `begin_update_upgrade` | ||
| - Model `ManagedClustersOperations` added method `begin_update` | ||
| - Model `NodeTypesOperations` added method `begin_deallocate` | ||
| - Model `NodeTypesOperations` added method `begin_redeploy` | ||
| - Model `NodeTypesOperations` added method `begin_start` | ||
| - Model `NodeTypesOperations` added method `begin_update` | ||
| - Model `ServicesOperations` added method `begin_restart_replica` |
There was a problem hiding this comment.
The CHANGELOG is missing the following new features that were added in this release:
- Model
ManagedClusterPropertiesadded propertyskip_managed_nsg_assignment - Model
NodeTypePropertiesadded propertyenable_resilient_ephemeral_os_disk
These new properties should be documented in the Features Added section.
| - Deleted or renamed model `UpgradeMode` | ||
| - Deleted or renamed method `ApplicationsOperations.update` | ||
| - Deleted or renamed method `ManagedClustersOperations.update` | ||
| - Deleted or renamed method `NodeTypesOperations.update` |
There was a problem hiding this comment.
The CHANGELOG should document the breaking change where monitoring policy timeout fields changed from datetime.timedelta type to str type. This affects the following model properties:
ClusterMonitoringPolicy:health_check_wait_duration,health_check_stable_duration,health_check_retry_timeout,upgrade_timeout,upgrade_domain_timeoutRollingUpgradeMonitoringPolicy:health_check_wait_duration,health_check_stable_duration,health_check_retry_timeout,upgrade_timeout,upgrade_domain_timeoutStatefulServiceProperties:replica_restart_wait_duration,quorum_loss_wait_duration,stand_by_replica_keep_duration,service_placement_time_limit
This is a significant breaking change as users who were passing timedelta objects will need to update their code to pass ISO 8601 formatted strings instead.
Suggested change
| - Deleted or renamed method `NodeTypesOperations.update` | |
| - Deleted or renamed method `NodeTypesOperations.update` | |
| - Model `ClusterMonitoringPolicy` changed the type of properties `health_check_wait_duration`, `health_check_stable_duration`, `health_check_retry_timeout`, `upgrade_timeout`, and `upgrade_domain_timeout` from `datetime.timedelta` to `str` (ISO 8601 duration). | |
| - Model `RollingUpgradeMonitoringPolicy` changed the type of properties `health_check_wait_duration`, `health_check_stable_duration`, `health_check_retry_timeout`, `upgrade_timeout`, and `upgrade_domain_timeout` from `datetime.timedelta` to `str` (ISO 8601 duration). | |
| - Model `StatefulServiceProperties` changed the type of properties `replica_restart_wait_duration`, `quorum_loss_wait_duration`, `stand_by_replica_keep_duration`, and `service_placement_time_limit` from `datetime.timedelta` to `str` (ISO 8601 duration). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2026-02-01, SDK Release Type: stable, and CommitSHA: '57a2504930224552a409d9435d523e631a6c93e2' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5919239 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7 Submitted by: iliu@microsoft.com
Release Plan Details
Spec pull request: [servicefabricmanagedclusters] 2026-02-01 azure-rest-api-specs#39563
Spec API version: 2026-02-01