Skip to content

[azure-core] Fix format_url dropping trailing slash when URL template is query-string only #45366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[azure-core] Fix format_url dropping trailing slash when URL template is query-string only #45366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7fa57e5
Initial plan
Copilot Feb 25, 2026
fcaf7bc
Fix format_url to preserve trailing slash when url_template is query-…
Copilot Feb 25, 2026
5d8bb45
Refine format_url fix: only preserve trailing slash for query-string-…
Copilot Feb 25, 2026
7cccfe9
Remove conditional rstrip from format_url (lines 671-675)
Copilot Feb 25, 2026
3d3886c
Apply suggestions from code review
pvaneck Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/core/azure-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Fixed `PipelineClient.format_url` to preserve trailing slash in the base URL when the URL template is query-string-only (e.g., `?key=value`). #45365

### Other Changes

## 1.38.2 (2026-02-18)
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core/azure/core/pipeline/transport/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ def format_url(self, url_template: str, **kwargs: Any) -> str:
parsed = urlparse(url)
if not parsed.scheme or not parsed.netloc:
try:
base = self._base_url.format(**kwargs).rstrip("/")
base = self._base_url.format(**kwargs)
except KeyError as key:
err_msg = "The value provided for the url part {} was incorrect, and resulted in an invalid url"
raise ValueError(err_msg.format(key.args[0])) from key
Expand Down
8 changes: 8 additions & 0 deletions sdk/core/azure-core/tests/test_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,14 @@ def test_format_url_query_strings():
assert formatted == "https://foo.core.windows.net/Tables?a=X&c=Y"


def test_format_url_trailing_slash_preserved_with_query_only():
# Test that trailing slash in base URL is preserved when url_template is query-string only
# https://github.com/Azure/azure-sdk-for-python/issues/45365
client = PipelineClientBase("{url}")
formatted = client.format_url("?versionid=2026-02-25", url="https://storage.blob.core.windows.net/sample//a/a/")
assert formatted == "https://storage.blob.core.windows.net/sample//a/a/?versionid=2026-02-25"


def test_format_url_from_http_request():
client = PipelineClientBase("https://foo.core.windows.net")

Expand Down
Loading