Create and execute query to return tables and interpolated names for Autoentities #3082
+308
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenCerna2079
changed the title
RubenCerna2079
requested review from
Alekhya-Polavarapu,
aaronburtle,
anushakolan,
neeraj-sharma2592,
rusamant,
sourabh1007,
souvikghosh04 and
vadeveka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MSSQL support for querying autoentities include/exclude patterns and interpolated entity names, and wires this into metadata initialization with unit test coverage.
Changes:
- Added a new
BuildGetAutoentitiesQueryAPI to the query builder abstraction and implemented it for MSSQL. - Added MSSQL metadata-provider methods to execute the autoentities query during initialization and expose results for tests.
- Added unit tests intended to validate autoentities query output and fixed a typo in
MsSqlQueryExecutormethod name.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Service.Tests/UnitTests/SqlMetadataProviderUnitTests.cs | Adds unit test for autoentities query output (currently has correctness/compilation issues). |
| src/Core/Services/MetadataProviders/SqlMetadataProvider.cs | Calls into autoentities generation during MSSQL initialization. |
| src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs | Adds autoentities query execution hooks (currently discards results). |
| src/Core/Resolvers/MsSqlQueryExecutor.cs | Fixes ConfigureMsSqlQueryExecutor method spelling. |
| src/Core/Resolvers/MsSqlQueryBuilder.cs | Adds MSSQL T-SQL batch to fetch eligible tables and interpolated entity names (currently unsafe/invalid). |
| src/Core/Resolvers/IQueryBuilder.cs | Adds new autoentities query builder API as a default interface method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
anushakolan
requested changes
Jan 28, 2026
github-project-automation
bot
moved this from Todo
to Review In Progress
in Data API builder
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
reviewed
Jan 29, 2026
Aniruddh25
reviewed
Jan 29, 2026
Aniruddh25
reviewed
Jan 29, 2026
Aniruddh25
reviewed
Jan 30, 2026
| "exclude_patterns AS ( SELECT LTRIM(RTRIM(value)) AS pattern FROM STRING_SPLIT(ISNULL(@exclude_pattern, N''), N',') " + | ||
| "WHERE LTRIM(RTRIM(value)) <> N'' ), all_tables AS ( SELECT s.name AS schema_name, t.name AS object_name, s.name + N'.' " + | ||
| "+ t.name AS full_name, N'table' AS object_type, t.object_id FROM sys.tables AS t JOIN sys.schemas AS s ON t.schema_id = s.schema_id " + | ||
| "WHERE EXISTS ( SELECT 1 FROM sys.key_constraints AS kc WHERE kc.parent_object_id = t.object_id AND kc.type = 'PK' ) ), eligible_tables AS " + |
Collaborator
There was a problem hiding this comment.
WHERE EXISTS
(
SELECT 1
FROM sys.key_constraints AS kc
WHERE kc.parent_object_id = t.object_id
AND kc.type = 'PK'
)
this condition is going to select only those tables which have PK constraint defined on them. Is that our intention? I dont think this should be what we do.
Contributor
Author
There was a problem hiding this comment.
While I agree with you on this, I think we need to discuss it with @JerryNixon
Aniruddh25
reviewed
Jan 30, 2026
Aniruddh25
reviewed
Jan 30, 2026
Aniruddh25
requested changes
Jan 30, 2026
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Need to parameterize the executed query.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
include&excludeproperties for autoentities #2966We need to create a query and send it to the database in order to receive all of the tables that will be turned into entities from the autoentities configuration. This includes the
schema,object, andentity name.What is this change?
schema,object, andentity name, an example of this would bedbo,book,dbo.book. The query also transforms the reserved words{schema}and{object}into the tables schema and object and returns it in the name.How was this tested?