Open
Conversation
bgavrilMS
reviewed
Feb 23, 2026
bgavrilMS
approved these changes
Feb 23, 2026
Avery-Dunn
reviewed
Feb 23, 2026
| self._http_client = http_client | ||
| self._oidc_authority_url = oidc_authority_url | ||
| if oidc_authority_url: | ||
| logger.debug("Initializing with OIDC authority: %s", oidc_authority_url) |
Contributor
There was a problem hiding this comment.
I think the flag was only on logging "openid_config" since it was a raw HTTP response.
But why remove these authority URL logs? Seems like useful info to help identify config issues.
Contributor
Author
There was a problem hiding this comment.
I can add it back, do we need this ?
Contributor
There was a problem hiding this comment.
Yeah, I think it's good to keep. I've definitely had trouble helping customers in the past because the logs didn't say where token requests were actually going.
Avery-Dunn
approved these changes
Feb 23, 2026
gladjohn
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed logs from oidc
Updated the version for msal python sku for release