spell haste #390
Open
spell haste #390
+436
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BreakBB
approved these changes
Jan 7, 2026
BreakBB
requested changes
Jan 7, 2026
Owner
BreakBB
left a comment
BreakBB
left a comment
There was a problem hiding this comment.
I forgot: A migration is required for this to actually work.
The hasteRating and hasteBonus stats have a isTbcOnly = true in the Profile.lua. That needs to be removed there and in a proper migration as well (setting it to nil).
Alessandro-Barbieri
force-pushed
the
spell-haste
branch
from
0719d7b to
767c352
Compare
BreakBB
requested changes
Jan 25, 2026
Owner
BreakBB
left a comment
BreakBB
left a comment
There was a problem hiding this comment.
Now only a Migration is needed so users actually see the haste values after an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368