Skip to content

Conversation

@Alessandro-Barbieri
Copy link
Contributor

Copy link
Owner

@BreakBB BreakBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can also somewhat streamline this implementation with _Melee:GetHitFromBuffs

@BreakBB
Copy link
Owner

BreakBB commented Jan 23, 2026

Also are you familiar with fixing the unit tests or should I take care of it?

@Alessandro-Barbieri
Copy link
Contributor Author

Also are you familiar with fixing the unit tests or should I take care of it?

No, I don't know what to do

@Alessandro-Barbieri
Copy link
Contributor Author

I guess we can also somewhat streamline this implementation with _Melee:GetHitFromBuffs

What do you mean with "streamline"? Reuse that function?

@BreakBB
Copy link
Owner

BreakBB commented Jan 25, 2026

Also are you familiar with fixing the unit tests or should I take care of it?

No, I don't know what to do

All you need to to is to replace the before_each in Ranged.test.lua with this:

    before_each(function()
        _G.ECS = {IsWotlk = false}
        _G.UnitClass = function()
            return "HUNTER", "HUNTER", 3
        end
        DataUtils = require("Modules.Data.DataUtils")
        Data = require("Modules.Data.Ranged")

        _G.C_UnitAuras = {
            GetPlayerAuraBySpellID = function() return nil end
        }
        _G.C_SpellBook = {
            IsSpellKnown = function() return false end
        }
    end)

@BreakBB BreakBB merged commit 0006f44 into BreakBB:master Jan 26, 2026
3 checks passed
@Alessandro-Barbieri Alessandro-Barbieri deleted the draenei branch January 26, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants