Fix Windows build: MSVC CRT and GPAC linking#2143
Open
cheron2000 wants to merge 1 commit intoCCExtractor:masterfrom
Open
Fix Windows build: MSVC CRT and GPAC linking#2143cheron2000 wants to merge 1 commit intoCCExtractor:masterfrom
cheron2000 wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 85aa833...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 85aa833...:
NOTE: The following tests have been failing on the master branch as well as the PR:
This PR does not introduce any new test failures. However, some tests are failing on both master and this PR (see above). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
{pull request content here}
[FIX] Fix Windows build: CRT linkage and GPAC integration
TL;DR
Fixes Windows build failures by enforcing dynamic MSVC CRT (/MD) across all targets (C, C++, Rust) and correcting GPAC linking. No impact on Linux/macOS.
Changes included:
1. CRT Configuration
src/CMakeLists.txtto enforce dynamic CRT across all targets.ccxlibrary target to use dynamic CRT insrc/lib_ccx/CMakeLists.txt.src/rust/CMakeLists.txt.2. GPAC Integration
src/CMakeLists.txtandsrc/lib_ccx/CMakeLists.txt.3. Platform-specific Fixes
if(NOT WIN32)to prevent Windows warnings.4. Cleanup
src/CMakeLists.txtandsrc/lib_ccx/CMakeLists.txt.Verification
Notes
C:/Program Files/GPAC/sdk/lib; users with different installations may need to update it./NODEFAULTLIB:libcmtto force dynamic CRT.This PR improves cross-platform build reliability and cleans up CMake configurations without affecting functionality.