Conversation
github-actions
bot
added
the
sync
|
This pull request has been marked to automatically sync to its base branch. You can disable this behavior by removing the label. |
There was a problem hiding this comment.
Pull request overview
Updates the 2025/26 committee data to reflect resignations and new role holders in the committee listing/archives.
Changes:
- Added
end-datefor the outgoing Socials Secretary and EDI Officer. - Added new entries for the incoming Socials Secretary and EDI Officer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| role: Socials Secretary | ||
| picture: /assets/committee/2025-26/mini/fearne.jpg | ||
| start-date: 1/7/2025 | ||
| end-date: 11/02/2026 |
There was a problem hiding this comment.
end-date values are parsed via Liquid's date filter in committee.html, and 11/02/2026 is ambiguous (could be 11 Feb or 2 Nov depending on parser). To avoid incorrect month/year display, use an unambiguous format like ISO-8601 (2026-02-11) for committee start/end dates.
| discordtag: | ||
| pronouns: | ||
| role: Socials Secretary | ||
| picture: /assets/committee/2025-26/mini/misha.jpg |
There was a problem hiding this comment.
picture points to /assets/committee/2025-26/mini/misha.jpg, but that file does not exist in assets/committee/2025-26/mini/ (and there is no corresponding file in assets/committee/2025-26/full/ either). This will produce a broken image on the Committee page; add the image assets (full + generated mini) or update the path to an existing image.
| picture: /assets/committee/2025-26/mini/misha.jpg | |
| picture: /assets/committee/2025-26/mini/fearne.jpg |
_data/committee/2025-26.yaml
Outdated
| bio: > | ||
| Bio here... |
There was a problem hiding this comment.
bio is currently placeholder text (Bio here...). Since this content is rendered directly onto the public Committee page, it should be replaced with the actual bio (or remove the bio field if intentionally blank and adjust rendering accordingly).
| bio: > | |
| Bio here... |
| role: Equality, Diversity, and Inclusivity Officer | ||
| picture: /assets/committee/2025-26/mini/sabrina.png | ||
| start-date: 1/7/2025 | ||
| end-date: 11/02/2026 |
There was a problem hiding this comment.
end-date values are parsed via Liquid's date filter in committee.html, and 11/02/2026 is ambiguous (could be 11 Feb or 2 Nov depending on parser). Use an unambiguous ISO-8601 date string (e.g. 2026-02-11) to ensure correct rendering/sorting.
_data/committee/2025-26.yaml
Outdated
| - name: Lee | ||
| discordtag: | ||
| pronouns: |
There was a problem hiding this comment.
This new member has discordtag: set to null/empty, but committee.html always renders {{ person.discordtag }} without a guard, which will display a blank Discord handle on the Committee page. Please populate discordtag (preferred), or update the template to only render the Discord tag element when the value is present.
| discordtag: | ||
| pronouns: | ||
| role: Equality, Diversity, and Inclusivity Officer | ||
| picture: /assets/committee/2025-26/mini/lee.jpg |
There was a problem hiding this comment.
picture points to /assets/committee/2025-26/mini/lee.jpg, but that file does not exist in assets/committee/2025-26/mini/ (and there is no corresponding file in assets/committee/2025-26/full/ either). This will produce a broken image on the Committee page; add the image assets (full + generated mini) or update the path to an existing image.
| picture: /assets/committee/2025-26/mini/lee.jpg |
| start-date: 11/02/2026 | ||
| bio: > |
There was a problem hiding this comment.
start-date: 11/02/2026 is ambiguous for Liquid/Ruby date parsing (could be interpreted as Nov 2 or Feb 11). Use an unambiguous ISO-8601 date string (e.g. 2026-02-11) so the Committee page renders the correct month.
_data/committee/2025-26.yaml
Outdated
| - name: Misha | ||
| discordtag: | ||
| pronouns: |
There was a problem hiding this comment.
This new member has discordtag: set to null/empty, but committee.html always renders {{ person.discordtag }} without a guard, which will display a blank Discord handle on the Committee page. Please populate discordtag (preferred), or update the template to only render the Discord tag element when the value is present.
| start-date: 11/02/2026 | ||
| bio: > |
There was a problem hiding this comment.
start-date: 11/02/2026 is ambiguous for Liquid/Ruby date parsing (could be interpreted as Nov 2 or Feb 11). Use an unambiguous ISO-8601 date string (e.g. 2026-02-11) so the Committee page renders the correct month.
_data/committee/2025-26.yaml
Outdated
| bio: > | ||
| Bio here... |
There was a problem hiding this comment.
bio is currently placeholder text (Bio here...). Since this content is rendered directly onto the public Committee page, it should be replaced with the actual bio (or remove the bio field if intentionally blank and adjust rendering accordingly).
3 participants
No description provided.