fix: update libtmux API calls for 0.33+ compatibility#159
Open
sgherdao wants to merge 3 commits intoCiscoDevNet:joe-devfrom
Open
fix: update libtmux API calls for 0.33+ compatibility#159sgherdao wants to merge 3 commits intoCiscoDevNet:joe-devfrom
sgherdao wants to merge 3 commits intoCiscoDevNet:joe-devfrom
Conversation
Replace deprecated methods removed in libtmux 0.51.0: - window.split_window() -> window.split() - session.attach_session() -> session.attach()
Pull Request Test Coverage Report for Build 21764913377Details
💛 - Coveralls |
Remove the <0.51 version constraint from libtmux to allow for newer versions of the library to be installed. The compatibility issue with version 0.51 has been resolved, so the upper bound is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.split_window()withwindow.split()session.attach_session()withsession.attach()These methods were deprecated in libtmux 0.33.0 and removed in 0.51.0, causing
cml tmuxto fail with:see https://libtmux.git-pull.com/migration.html
Changes
virl/cli/tmux/commands.py: Updated API callstests/v2/tmux.py: Updated mocks to match new APIrequirements.txt: Relax libtmux requirements (same as before)Testing
All 122 tests pass.