Open
Conversation
Collaborator
dzinpa
commented
Oct 28, 2020
dzinpa
commented
- Added codeception library
- Created simple test
- Added codeception framework
- Created simple test
enduro44
requested changes
Oct 29, 2020
composer.json
Outdated
| "codeception/module-asserts": "^1.0.0" | ||
| }, | ||
| "scripts": { | ||
| "test": ".\\vendor\\bin\\codecept.bat run", |
Contributor
There was a problem hiding this comment.
this will work only for windows
tests/unit/DbQueryCest.php
Outdated
| public function testOrder(UnitTester $I) | ||
| { | ||
| $dbOrder = new \CleanBandits\DbQuery\Order\DbOrder(['id','ASC']); | ||
| $I->assertSame('0 id,1 ASC',$dbOrder->orderingFormatted()); |
README.md
Outdated
| # Db Query | ||
| Simple PHP OOP library for creating database queries. | ||
|
|
||
| Run tests using: composer test No newline at end of file |
Contributor
There was a problem hiding this comment.
Documentation should be updated properly. Introduce new section Contribution, sub section Development and subsub section Testing.
Need to add description hav to setup testing - e.g. copy codeception.yml-dist to codeception.yml, etc.
- Updated readme file. - Changed script run command.
enduro44
requested changes
Nov 18, 2020
| @@ -0,0 +1,10 @@ | |||
| paths: | |||
| tests: tests | |||
Contributor
There was a problem hiding this comment.
this file can stay in source as codeception.yml, no need for dist
Basicly easier is ti setup and run tests, than better.
tests/acceptance.suite.yml-dist
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Codeception Test Suite Configuration | |||
| # | |||
| # Suite for acceptance tests. | |||
Contributor
There was a problem hiding this comment.
no need for acceptance and functional tests for now
- Updated readme file. - Removed acceptance and functional files - Removed 'dist' files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.