Skip to content

Fix ruff upgrade #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoMPaTech merged 1 commit into from
Feb 24, 2026
Merged

Fix ruff upgrade #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ default_language_version:
repos:
# Run manually in CI skipping the branch checks
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.14.14
rev: v0.15.2
hooks:
- id: ruff
name: "Ruff check"
Expand Down
10 changes: 3 additions & 7 deletions airos/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,8 @@ def __init__(
self.api_version: int = 8

parsed_host = urlparse(host)
scheme = (
parsed_host.scheme
if parsed_host.scheme
else ("https" if use_ssl else "http")
)
hostname = parsed_host.hostname if parsed_host.hostname else host
scheme = parsed_host.scheme or ("https" if use_ssl else "http")
hostname = parsed_host.hostname or host

self.base_url = f"{scheme}://{hostname}"
Comment on lines 60 to 64
Copy link

@coderabbitai coderabbitai bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, find airos/base.py and read the relevant lines
git ls-files | grep -E 'airos.*base\.py'

Repository: CoMPaTech/python-airos

Length of output: 79

🏁 Script executed:

#!/bin/bash
# Read the code around lines 60-64 in airos/base.py to see exact implementation
find . -name 'base.py' -path '*/airos/*' -type f | head -5

Repository: CoMPaTech/python-airos

Length of output: 81

🏁 Script executed:

#!/bin/bash
# Search for how this class is instantiated with host parameter
rg -n 'class.*\(.*\):' airos/ | grep -i base

Repository: CoMPaTech/python-airos

Length of output: 345

🏁 Script executed:

#!/bin/bash
# Read the __init__ method and surrounding code in airos/base.py
sed -n '39,100p' airos/base.py | cat -n

Repository: CoMPaTech/python-airos

Length of output: 2739

🏁 Script executed:

#!/bin/bash
# Search for instantiation of AirOS class with host parameter
rg -n 'AirOS\(' -A 2 --type=py | head -50

Repository: CoMPaTech/python-airos

Length of output: 194

🏁 Script executed:

#!/bin/bash
# Also search for test files that show how this class is used
find . -name '*test*.py' -type f | xargs grep -l 'AirOS' | head -3

Repository: CoMPaTech/python-airos

Length of output: 131

🏁 Script executed:

#!/bin/bash
# Read test files to see how host is passed
cat tests/conftest.py | head -100

Repository: CoMPaTech/python-airos

Length of output: 2155

🏁 Script executed:

#!/bin/bash
# Search for host parameter values in tests
rg -n 'host\s*=' tests/ -A 1 -B 1

Repository: CoMPaTech/python-airos

Length of output: 1650

🏁 Script executed:

#!/bin/bash
# Search for AirOS instantiation in tests showing host parameter
rg -n 'AirOS\(' tests/ -A 5 | head -80

Repository: CoMPaTech/python-airos

Length of output: 48

🏁 Script executed:

#!/bin/bash
# Search for any host parameter with explicit port numbers in the codebase
rg -n ':\d+' airos/ tests/ --type=py | grep -E '(host|url).*:\d+'

Repository: CoMPaTech/python-airos

Length of output: 48

🏁 Script executed:

#!/bin/bash
# Check if there's any documentation or examples showing port usage
find . -name 'README*' -o -name '*.md' | xargs grep -l 'port\|:\d\d\d\d' 2>/dev/null | head -5

Repository: CoMPaTech/python-airos

Length of output: 106

🏁 Script executed:

#!/bin/bash
# Let's verify the urlparse behavior with a quick Python test
python3 << 'EOF'
from urllib.parse import urlparse

# Test cases showing the difference between hostname and netloc
test_cases = [
    "192.168.1.3",
    "http://192.168.1.3",
    "https://example.com:8443",
    "http://device.local:9000",
    "device.local",
]

print("URL | hostname | netloc")
print("-" * 60)
for url in test_cases:
    parsed = urlparse(url)
    print(f"{url:30} | {parsed.hostname or 'None':20} | {parsed.netloc or 'None'}")
EOF

Repository: CoMPaTech/python-airos

Length of output: 487

Preserve explicit ports in base_url.
parsed_host.hostname drops the port (e.g., https://example.com:8443 → example.com), causing requests to fail for non-standard ports. Use netloc instead:

 parsed_host = urlparse(host)
 scheme = parsed_host.scheme or ("https" if use_ssl else "http")
-hostname = parsed_host.hostname or host
+netloc = parsed_host.netloc or host
-self.base_url = f"{scheme}://{hostname}"
+self.base_url = f"{scheme}://{netloc}"

Current tests pass hosts without explicit ports, so this bug is latent. However, any caller providing host with a port (e.g., via configuration or discovery) will experience connection failures.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
parsed_host = urlparse(host)
scheme = (
parsed_host.scheme
if parsed_host.scheme
else ("https" if use_ssl else "http")
)
hostname = parsed_host.hostname if parsed_host.hostname else host
scheme = parsed_host.scheme or ("https" if use_ssl else "http")
hostname = parsed_host.hostname or host
self.base_url = f"{scheme}://{hostname}"
parsed_host = urlparse(host)
scheme = parsed_host.scheme or ("https" if use_ssl else "http")
netloc = parsed_host.netloc or host
self.base_url = f"{scheme}://{netloc}"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@airos/base.py` around lines 60 - 64, The current construction of
self.base_url uses parsed_host.hostname which drops explicit ports; update the
logic in the url parsing block (symbols: urlparse, parsed_host, scheme, use_ssl,
hostname, base_url) to use parsed_host.netloc (falling back to host if netloc is
empty) when composing the authority portion so ports are preserved; keep the
existing scheme selection (parsed_host.scheme or ("https" if use_ssl else
"http")) and then set self.base_url = f"{scheme}://{netloc}" (with netloc
defaulting to host when needed).


Expand Down Expand Up @@ -309,7 +305,7 @@ async def _request_json(
)
if err.status in [401, 403]:
raise AirOSConnectionAuthenticationError from err
if err.status in [404]:
if err.status == 404:
raise AirOSUrlNotFoundError from err
raise AirOSConnectionSetupError from err
except (TimeoutError, aiohttp.ClientError) as err:
Expand Down