Skip to content

chore: turn warning about overwritten unwind_data into debug logs #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeLagrange merged 1 commit into from
Jan 28, 2026
Merged

chore: turn warning about overwritten unwind_data into debug logs #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/runner-shared/src/unwind_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,17 @@ impl UnwindData {

pub fn to_file<P: AsRef<std::path::Path>>(&self, path: P) -> anyhow::Result<()> {
if let Ok(true) = std::fs::exists(path.as_ref()) {
log::warn!(
// This happens in CI for the root `systemd-run` process which execs into bash which
// also execs into bash, each process reloading common libraries like `ld-linux.so`.
// We detect this when we harvest unwind_data by parsing the perf data (exec-harness).
// Until we properly handle the process tree and deduplicate unwind data, just debug
// log here
// Any relevant occurence should have other symptoms reported by users.
log::debug!(
"{} already exists, file will be truncated",
path.as_ref().display()
);
log::warn!("{} {:x?}", self.path, self.avma_range);
log::debug!("{} {:x?}", self.path, self.avma_range);
}

let compat = UnwindDataCompat::V2(self.clone());
Expand Down
Loading