feat: add memory profiling support #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
force-pushed
the
cod-2105-support-memory-profiling-for-python
branch
from
55eeef1 to
4bd794f
Compare
not-matthias
force-pushed
the
cod-2105-support-memory-profiling-for-python
branch
from
2351156 to
c6a08d7
Compare
Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
GuillaumeLagrange
approved these changes
Jan 29, 2026
| # Manually call the library function to avoid an extra stack frame. Also | ||
| # call the callgrind markers directly to avoid extra overhead. | ||
| self.instrument_hooks.lib.callgrind_start_instrumentation() | ||
| self.instrument_hooks.start_benchmark() |
Contributor
There was a problem hiding this comment.
What happened to the original comment here ?
Is the extra stack frame no longer an issue ?
| finally: | ||
| # Ensure instrumentation is stopped even if the test failed | ||
| self.instrument_hooks.lib.callgrind_stop_instrumentation() | ||
| self.instrument_hooks.stop_benchmark() |
Contributor
There was a problem hiding this comment.
kinda same remark here
| f"callgraph: {'enabled' if SUPPORTS_PERF_TRAMPOLINE else 'not supported'}" | ||
| ) | ||
| warnings = [] | ||
| warns = [] |
Contributor
There was a problem hiding this comment.
not sure about this renaming, is there any reason?
| instrument_hooks: InstrumentHooks | None | ||
|
|
||
| def __init__(self, config: CodSpeedConfig) -> None: | ||
| def __init__(self, config: CodSpeedConfig, mode: MeasurementMode) -> None: |
Contributor
There was a problem hiding this comment.
doesnt this lead to some kind of linter error for unused argument ? Just curious
| - name: Run benchmarks | ||
| uses: CodSpeedHQ/action@main | ||
| with: | ||
| runner-version: branch:cod-2105-support-memory-profiling-for-python |
Contributor
There was a problem hiding this comment.
do not forget to drop this commit
| sudo apt-get install valgrind -y | ||
| uv sync --dev | ||
| sudo apt-get remove valgrind -y | ||
| - uses: dtolnay/rust-toolchain@stable |
| def get_instrument_config_str_and_warns(self) -> tuple[str, list[str]]: | ||
| config = ( | ||
| f"instrument: {self.mode.value}, " | ||
| f"mode: {self.mode.value}, " |
Contributor
There was a problem hiding this comment.
dont forget to fixup aswell
GuillaumeLagrange
requested changes
Jan 29, 2026
Contributor
GuillaumeLagrange
left a comment
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Sorry I meant to request changes
Especially we need to validate the extra stack frame thing in instrumentation by comparing the output to a real prod run!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.