Add walltime benchmarking algorithm to exec-harness #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
5987856 to
7c43710
Compare
not-matthias
reviewed
Jan 6, 2026
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
A few minor things that can be improved, otherwise looks really good! :)
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
4 times, most recently
from
4877ad0 to
46b0925
Compare
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
46b0925 to
0bde17f
Compare
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
0bde17f to
69b37a2
Compare
adriencaccia
requested changes
Jan 13, 2026
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
69b37a2 to
a9970fd
Compare
adriencaccia
requested changes
Jan 13, 2026
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
a9970fd to
3f66285
Compare
GuillaumeLagrange
force-pushed
the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
from
3f66285 to
2dd2b9c
Compare
adriencaccia
requested changes
Jan 13, 2026
| None, | ||
| ); | ||
|
|
||
| dbg!(vec![42, 42 * 2, 42 * 3, 42 * 4, 42 * 5, 42 * 6]); |
Updated the tests with values outputted by the same implementation as pytest.
adriencaccia
approved these changes
Jan 14, 2026
GuillaumeLagrange
deleted the
cod-1904-benchmarking-algorithm-in-the-exec-harness-with-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.