-
Notifications
You must be signed in to change notification settings - Fork 356
Address code review feedback: security, responsive design, and code deduplication #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…dling, and code quality Co-authored-by: Avdhesh-Varshney <114330097+Avdhesh-Varshney@users.noreply.github.com>
Co-authored-by: Avdhesh-Varshney <114330097+Avdhesh-Varshney@users.noreply.github.com>
|
@copilot settings option integrations is not seems to be selected as making both the sidebars to be common |
I can see in the screenshot that the "Integrations" option in the settings sidebar (left side) appears to be highlighted with a blue background, which indicates it is selected. Could you clarify what specific issue you're seeing? Are you saying:
Please provide more details so I can address the issue correctly. |
|
@copilot The "Integrations" option should NOT be highlighted when viewing OpenAI integration page? and even not highlight profile option when viewing profile page |
Co-authored-by: Avdhesh-Varshney <114330097+Avdhesh-Varshney@users.noreply.github.com>
Fixed in commit 3159089. The settings sidebar items (Profile, Integrations) now remain unhighlighted when viewing their detail pages. They will only show hover effects when you move your cursor over them. |
Addresses code review comments from PR #1345 regarding security vulnerabilities, missing user feedback, responsive design issues, and code duplication in the integrations settings page.
Security
'*'.repeat(apiKey.length)) with fixed 16-character bullet stringUser Experience
useNotificationshookwidth: { xs: '100%', md: '50%' }for mobile/desktopCode Quality
SidebarItemcomponent (~100+ lines eliminated)locked: falseproperties from route definitionstypefield fromIntegrationSettingTypeinterfacepl: 4)Before (duplicated in both Settings and Integrations):
After (shared component):
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.