Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026

Addresses code review comments from PR #1345 regarding security vulnerabilities, missing user feedback, responsive design issues, and code duplication in the integrations settings page.

Security

  • Fixed API key length exposure: replaced variable-length masking ('*'.repeat(apiKey.length)) with fixed 16-character bullet string
  • Prevents inferring actual key length from UI

User Experience

  • Added toast notifications for connect/disconnect operations using existing useNotifications hook
  • Made API key input responsive: width: { xs: '100%', md: '50%' } for mobile/desktop
  • Removed active state highlighting from settings sidebar items (Profile, Integrations) so they remain unhighlighted when viewing their detail pages

Code Quality

  • Extracted duplicate sidebar rendering into reusable SidebarItem component (~100+ lines eliminated)
  • Removed redundant locked: false properties from route definitions
  • Removed unused type field from IntegrationSettingType interface
  • Fixed icon sizing inconsistency (24px → 20px for OpenAI icon)
  • Replaced magic number padding with theme spacing (pl: 4)

Before (duplicated in both Settings and Integrations):

<ButtonBase component="div" sx={{ width: '100%', p: 2, /* ...150+ lines of styling */ }}>
  {/* Complex nested Box structure with icons, typography, lock badges */}
</ButtonBase>

After (shared component):

<SidebarItem
  id={id}
  name={name}
  icon={icon}
  isActive={isActive}
  isLastItem={isLastItem}
/>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Jan 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
code-a2z Ready Ready Preview, Comment Jan 11, 2026 4:25pm
code-a2z-server Ready Ready Preview, Comment Jan 11, 2026 4:25pm

…dling, and code quality

Co-authored-by: Avdhesh-Varshney <114330097+Avdhesh-Varshney@users.noreply.github.com>
Co-authored-by: Avdhesh-Varshney <114330097+Avdhesh-Varshney@users.noreply.github.com>
Copilot AI changed the title [WIP] Add integrations settings page Address code review feedback: security, responsive design, and code deduplication Jan 11, 2026
@Avdhesh-Varshney
Copy link
Collaborator

@copilot settings option integrations is not seems to be selected as making both the sidebars to be common

Copy link
Contributor Author

Copilot AI commented Jan 11, 2026

@copilot settings option integrations is not seems to be selected as making both the sidebars to be common

I can see in the screenshot that the "Integrations" option in the settings sidebar (left side) appears to be highlighted with a blue background, which indicates it is selected. Could you clarify what specific issue you're seeing?

Are you saying:

  1. The "Integrations" option should NOT be highlighted when viewing OpenAI integration page?
  2. The highlighting is not visible enough or has the wrong style?
  3. Something else is not working as expected?

Please provide more details so I can address the issue correctly.

@Avdhesh-Varshney
Copy link
Collaborator

@copilot The "Integrations" option should NOT be highlighted when viewing OpenAI integration page? and even not highlight profile option when viewing profile page

Co-authored-by: Avdhesh-Varshney <114330097+Avdhesh-Varshney@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 11, 2026

@copilot The "Integrations" option should NOT be highlighted when viewing OpenAI integration page? and even not highlight profile option when viewing profile page

Fixed in commit 3159089. The settings sidebar items (Profile, Integrations) now remain unhighlighted when viewing their detail pages. They will only show hover effects when you move your cursor over them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants