Skip to content

Comments

Fix SaveList loading issue and form warning#1794

Open
hiShwetank wants to merge 1 commit intoCodePhiliaX:mainfrom
hiShwetank:main
Open

Fix SaveList loading issue and form warning#1794
hiShwetank wants to merge 1 commit intoCodePhiliaX:mainfrom
hiShwetank:main

Conversation

@hiShwetank
Copy link

gh pr create --title "Fix SaveList loading issue and form warning" --body "## Issues Fixed:

  • ✅ SaveList was stuck in loading state when no saved consoles exist
  • ✅ useForm warning in Modal due to missing Form wrapper
  • ✅ Code quality improvements (removed unused variables)

Changes:

  • LoadingContent: Fixed empty array handling logic to show empty state instead of loading
  • SaveList: Added Form wrapper with proper validation to fix useForm connection warning

Testing:

  • Empty state now shows correctly when no saved consoles exist
  • Form validation works properly for rename functionality
  • No console warnings or errors
  • Loading state works correctly during data fetching

This fix improves user experience by showing proper empty states and eliminates console warnings."

- Fix LoadingContent component to properly handle empty arrays
- Add Form wrapper to Modal to fix useForm connection warning
- Remove unused variables and improve code quality
- SaveList now shows empty state correctly when no saved consoles exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant