-
-
Notifications
You must be signed in to change notification settings - Fork 375
West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 2 | Form Controls #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @jenny-alexander, can you please review this PR? As it has been under review for progress since yesterday. Thank you! |
|
If all the requirements are met, can you please change the review to 'complete'? |
I appreciate you wanting to move quickly on this! Just so you know, I typically try to review PRs within 24-48 hours after assigning them to myself. |
jenny-alexander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alizada-dev - nice work with the form control exercise 👍 I can see that you have a good understanding of HTML form basics!
- Please check the accessibility rating of your form. Currently it is '89' in Lighthouse.
- I left a few comments for you to review in order to improve code quality and the 'look' of the form.
|
Dear @jenny-alexander, thank you so much for dedicating time to reviewing my PR. I actually learned new concepts when I implemented your suggested changes. |
|
Thanks for making those changes - the form looks great! 👏 |

Self checklist
Created an HTML form to collect the name and email address of the customers along with their size and color preferences. The form is validated with built-in HTML validation.