Glasgow | Jan-26 | Elisabeth Matulian | Sprint 1 | Wireframe #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Elisabeth-Matulian
changed the title
Elisabeth-Matulian
added
the
Needs Review
jenny-alexander
added
Review in progress
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
Hey @Elisabeth-Matulian 👋🏻 - you've added some good content to your wireframe exercise! I left a few suggestions for you to make in order to enhance your code submission.
| more</a> | ||
| </article> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you add an image related to the article topic?
| <a href="https://www.productplan.com/glossary/wireframe/">Read more</a> | ||
| </article> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you add an image related to the article topic?
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Can you add an image related to the article topic?
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. |
There was a problem hiding this comment.
💭 Perhaps you could add a little bit of information to the footer. This could be:
- contact email address or link
- a few social links to CYF
- a copyright notice like '© 2026 [Name]'
jenny-alexander
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I arranged the blocks according to the provided template. I fixed the footer at the bottom of the page and filled the blocks with articles.
Questions
Needs review