Skip to content

Sheffield | 26-ITP-Jan | Daniel Aderibigbe | Sprint 2 | Form Controls #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dan2Clouted wants to merge 1 commit into
base: main
Choose a base branch
from
+104 −5
Open

Sheffield | 26-ITP-Jan | Daniel Aderibigbe | Sprint 2 | Form Controls #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 104 additions & 5 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,114 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<fieldset>
<legend>Customer details</legend>
Copy link
Contributor

@cjyuan cjyuan Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<legend>Customer details</legend>
<legend>Customer Details</legend>


<label for="name">Name:</label>
<input
type="text"
id="name"
required
name="customerName"
minlength="2"
/>
Comment on lines +20 to +26
Copy link
Contributor

@cjyuan cjyuan Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

<br /><br />
<label for="email">Email:</label>
<input type="email" id="email" required name="customerEmail" />
</fieldset>

<br />
<fieldset>
<legend>T-Shirt Colour</legend>

<div>
<input
type="radio"
id="colourBlack"
name="tshirtColour"
value="black"
required
/>
<label for="colourBlack">Black</label>
</div>

<br />

<div>
<input
type="radio"
id="colourWhite"
name="tshirtColour"
value="white"
/>
<label for="colourWhite">White</label>
</div>

<br />

<div>
<input
type="radio"
id="colourBlue"
name="tshirtColour"
value="blue"
/>
<label for="colourBlue">Blue</label>
</div>
</fieldset>

<fieldset>
<legend>T-Shirt Size</legend>

<div>
<input type="radio" id="sizeXS" name="size" value="XS" required />
<label for="sizeXS">XS</label>
</div>

<br />

<div>
<input type="radio" id="sizeS" name="size" value="S" required />
<label for="sizeS">S</label>
</div>

<br />

<div>
<input type="radio" id="sizeM" name="size" value="M" required />
<label for="sizeM">M</label>
</div>

<br />

<div>
<input type="radio" id="sizeL" name="size" value="L" required />
<label for="sizeL">L</label>
</div>

<br />

<div>
<input type="radio" id="sizeXL" name="size" value="XL" required />
<label for="sizeXL">XL</label>
</div>

<br />

<div>
<input type="radio" id="sizeXXL" name="size" value="XXL" required />
<label for="sizeXXL">XXL</label>
</div>
</fieldset>

<br />

<button type="submit">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Daniel Aderibigbe</h2>
</footer>
</body>
</html>
Loading