Skip to content

Conversation

@harley
Copy link
Contributor

@harley harley commented Sep 27, 2025

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @harley, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability and maintainability of timer-based operations within the application. It standardizes delay durations using named constants, adds safeguards against interacting with disconnected DOM elements after a delay, and improves the management of save status indicators in the options page by ensuring proper cleanup of pending timers.

Highlights

  • Timer Management Refinement: Introduced named constants for delay durations (PROMPT_RESET_DELAY_MS, SAVE_STATUS_RESET_DELAY_MS) to improve readability and maintainability, replacing magic numbers.
  • DOM Element Safety: Added a guard (if (!promptButton.isConnected)) to prevent potential errors when a setTimeout callback attempts to interact with a DOM element that has been removed from the document.
  • Robust Save Status Handling: Implemented useRef to manage the setTimeout ID for resetting the save status in the options page. This includes clearing previous timeouts on new save attempts and on component unmount, preventing race conditions and memory leaks.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces safeguards for timers to prevent them from executing on detached DOM elements or unmounted React components. The changes are well-implemented and follow best practices. In contentScript/index.ts, a check for promptButton.isConnected is added before modifying the button state in a setTimeout. In Options.tsx, useRef and a useEffect cleanup function are used to properly manage a timer's lifecycle, clearing it on component unmount or when a new action is triggered. The use of constants for timer delays also improves code readability. Overall, these are solid improvements that increase the robustness of the code.

@harley harley merged commit 214114e into main Sep 27, 2025
1 check passed
@harley harley deleted the fix/prompt-timeout-guards branch September 27, 2025 04:35
harley added a commit that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants