feat: use qs_dart in buildUrlString for enhanced query string encoding#158
Merged
CodingAleCR merged 6 commits intoCodingAleCR:mainfrom Jul 22, 2025
Merged
feat: use qs_dart in buildUrlString for enhanced query string encoding#158CodingAleCR merged 6 commits intoCodingAleCR:mainfrom
buildUrlString for enhanced query string encoding#158CodingAleCR merged 6 commits intoCodingAleCR:mainfrom
Conversation
Contributor
Author
|
@CodingAleCR I have added URL validation to the |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # lib/utils/query_parameters.dart # test/utils/utils_test.dart
buildUrlStringbuildUrlString for enhanced query string encoding
CodingAleCR
approved these changes
Jul 22, 2025
Owner
|
@all-contributors add @techouse for code and docs |
Contributor
|
I've put up a pull request to add @techouse! 🎉 |
Owner
Thank you for contributing to the library, I'm sorry it took so long 🙏🏻 |
Contributor
Author
|
@CodingAleCR no worries 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hi there! I’m the author of qs_dart, a Dart port of qs for JavaScript.
I’ve given the
buildUrlStringutility method a thorough overhaul to boost its reliability and maintainability. Below is a summary of the key improvements:🚀 Core Enhancements
ArgumentErrorfor malformed or non-HTTP(S) URLsUri.parseand basic checks - no more ad-hoc string assumptions🛠️ New Dependencies
✅ Expanded Test Coverage
Added new cases in test/utils/utils_test.dart to validate:
null/ empty maps, empty‐string values, overriding existing keys@,/), spaces vs. plus signsThese tests ensure that
buildUrlStringbehaves correctly across all common and edge scenarios.