Squashed commit of the following:#269
Closed
danielbanda wants to merge 3 commits intoCommunityToolkit:mainfrom
Closed
Squashed commit of the following:#269danielbanda wants to merge 3 commits intoCommunityToolkit:mainfrom
danielbanda wants to merge 3 commits intoCommunityToolkit:mainfrom
Conversation
commit f77303a Author: Daniel Banda <daniel_banda@hotmail.com> Date: Tue May 3 21:43:11 2022 -0700 Reverting accidental commit. Reverting accidental commit. commit ea9740b Author: Daniel Banda <daniel_banda@hotmail.com> Date: Tue May 3 21:30:55 2022 -0700 Fixing typos Found some typos while reviewing the library. commit f2dce06 Author: Daniel Banda <daniel_banda@hotmail.com> Date: Tue May 3 21:21:10 2022 -0700 Fixing some typos.
Nirmal4G
suggested changes
May 25, 2022
Contributor
Nirmal4G
left a comment
Nirmal4G
left a comment
There was a problem hiding this comment.
LGTM but do change the commit message. You don't need to refer individual commits in the message.
Suggested commit message:
Fixed typos in code and comments
Fixing typos in code and comments.
Member
|
Why would you open a separate PR for the same changes? I just asked to rebase the previous one 🥲 If you're not familiar with git (or at least, with rebases), I can either take care of this or help guide you through it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85
Fixed some documentation typos 😉
PR Checklist
@Sergio0694 @Nirmal4G same as #237 but squashed.