Skip to content

Conversation

@CoshUS
Copy link
Owner

@CoshUS CoshUS commented Nov 8, 2021

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS CoshUS changed the title Example PR Example PR 1 Nov 8, 2021
@CoshUS
Copy link
Owner Author

CoshUS commented Nov 9, 2021

Comment 1

@CoshUS
Copy link
Owner Author

CoshUS commented Nov 9, 2021

Comment 2

@CoshUS
Copy link
Owner Author

CoshUS commented Nov 9, 2021

Comment 3

from samcli.lib.utils import osutils
from samcli.lib.bootstrap.bootstrap import manage_stack
from samcli.lib.utils.version_checker import check_newer_version
from samcli.lib.bootstrap.companion_stack.companion_stack_manager import sync_ecr_stack
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Review Comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants