feat: Support properties on license#1383
Open
peschuster wants to merge 1 commit intoCycloneDX:mainfrom
Open
Conversation
jkowalleck
requested changes
Feb 23, 2026
Member
jkowalleck
left a comment
jkowalleck
left a comment
There was a problem hiding this comment.
Thank you for working on this feature.
See my remarks below
src/spec/_protocol.ts
Outdated
| supportsMetadataProperties: boolean | ||
| supportsExternalReferenceHashes: boolean | ||
| supportsLicenseAcknowledgement: boolean | ||
| supportsLicenseProperties: boolean |
Member
There was a problem hiding this comment.
please, dont add a new property supportsLicenseProperties for this.
instead, alter the existing function supportsProperties() accordingly. something like
supportsProperties (model: any): boolean {
switch (true) {
case model instanceof NamedLicense || model instanceof SpdxLicense:
return this.#supportsLicenseProperties
default:
return this.#supportsProperties
}
}the idea is: we dont have a public spec.supportsSomethingProperties for each and every thing. instead, we have the method spec.supportsProperties(someDataModel)
src/spec/_protocol.ts
Outdated
| supportsMetadataProperties: boolean, | ||
| supportsExternalReferenceHashes: boolean, | ||
| supportsLicenseAcknowledgement: boolean, | ||
| supportsLicenseProperties: boolean, |
Member
There was a problem hiding this comment.
move the new argument at the bottom,
or move it behind the supportsProperties
src/serialize/json/normalize.ts
Outdated
| url: JsonSchema.isIriReference(url) | ||
| ? url | ||
| : undefined, | ||
| properties: spec.supportsProperties(data) && spec.supportsLicenseProperties && data.properties.size > 0 |
Member
There was a problem hiding this comment.
Suggested change
| properties: spec.supportsProperties(data) && spec.supportsLicenseProperties && data.properties.size > 0 | |
| properties: data.properties.size > 0 && spec.supportsProperties(data) |
src/serialize/xml/normalize.ts
Outdated
| const url = escapeUri(data.url?.toString()) | ||
| const spec = this._factory.spec | ||
| const url = escapeUri(data.url?.toString()) | ||
| const properties: SimpleXml.Element | undefined = spec.supportsProperties(data) && spec.supportsLicenseProperties && data.properties.size > 0 |
Member
There was a problem hiding this comment.
Suggested change
| const properties: SimpleXml.Element | undefined = spec.supportsProperties(data) && spec.supportsLicenseProperties && data.properties.size > 0 | |
| const properties: SimpleXml.Element | undefined = data.properties.size > 0 && spec.supportsProperties(data) |
src/serialize/xml/normalize.ts
Outdated
| const url = escapeUri(data.url?.toString()) | ||
| const spec = this._factory.spec | ||
| const url = escapeUri(data.url?.toString()) | ||
| const properties: SimpleXml.Element | undefined = spec.supportsProperties(data) && spec.supportsLicenseProperties && data.properties.size > 0 |
Member
There was a problem hiding this comment.
Suggested change
| const properties: SimpleXml.Element | undefined = spec.supportsProperties(data) && spec.supportsLicenseProperties && data.properties.size > 0 | |
| const properties: SimpleXml.Element | undefined = data.properties.size > 0 && spec.supportsProperties(data) |
jkowalleck
added
enhancement
Signed-off-by: Peter Schuster <p.schuster@pilz.de>
peschuster
force-pushed
the
feat/property-support-for-license
branch
from
4cef7ee to
2bb7604
Compare
Author
|
Thanks for the review and feedback. The new version of the diff should address all comments and requests for changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for "properties" on named and spdx licenses available with since schema version 1.5
AI Tool Disclosure
Affirmation