feat: Add the possibility to use the dirac-cwl project's job wrapper#8425
feat: Add the possibility to use the dirac-cwl project's job wrapper#8425fstagni merged 10 commits intoDIRACGrid:integrationfrom
Conversation
aldbr
left a comment
There was a problem hiding this comment.
Looks good to me!
Note for the other reviewer: the new job wrapper is experimental and is not expected to be executed at a large scale. It's only meant to be used for a few jobs in parallel for now.
@Loxeris have you tested it using the SingularityComputingElement?
The JobAgent can use the SingularituComputingElement instead of the InProcessComputingElement. In that case, the job wrapper is generated in a slightly different way:
DIRAC/src/DIRAC/Resources/Computing/SingularityComputingElement.py
Lines 211 to 222 in 11bc43d
@aldbr I believe the computing element used by the CTAO test instance I did end-to-end tests on is |
|
Just to say that that PR must first be tested using the DIRAC certification setup (instructions not written down yet, will be there for the hackathon next week) |
experimental JobWrapper integration using git cloning
bbb9a25 to
a57374e
Compare
a57374e to
e3fa64d
Compare
|
@Loxeris managed to test the PR in certification. |
|
It could be interesting to pass the JobID to the cwl Job Wrapper in this PR, as it seems to be needed for job reports and future development in the dirac-cwl repo. |
Please verify if that's actually needed, and open issue if it is. Merging this one now. |
Adds slights changes to
create_job_wrapper()to use the experimental Job Wrapper for CWL jobs.If the job executable is set to
dirac-cwl-execin the JDL, the new job wrapper is used, else thedefaultWrapperLocationis used like before.The dirac-cwl project is cloned locally on the pilot to get the latest version of the job wrapper before being run.
See DIRACGrid/dirac-cwl#44
BEGINRELEASENOTES
*WorkloadManagementSystem
NEW: Experimental job wrapper for cwl workflows
ENDRELEASENOTES