Added SplitOn functionality #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: devedse <2350015+devedse@users.noreply.github.com>
…ation Co-authored-by: devedse <2350015+devedse@users.noreply.github.com>
…n framework Co-authored-by: devedse <2350015+devedse@users.noreply.github.com>
…ed clarity and functionality
…n and improve readability
…eForNew method in CodeWriter
…and initialize remaining tokens - Updated the Tokenize method across multiple interceptors to calculate the number of available columns based on the reader's FieldCount and the columnOffset. - Introduced a tokenCount variable to limit the loop iteration to the lesser of the tokens length and available columns. - Added logic to initialize any remaining tokens to -1 (unmapped) after processing available columns, ensuring that all tokens are accounted for.
- Added handling for unmapped columns in various interceptors by introducing a case for -1, which skips unmapped columns during data reading. - Updated Tokenize methods to initialize remaining tokens to -1 for unmapped columns. - Adjusted output files for QueryCustomConstructionWithFactoryMethod, QueryDetection, QueryMultiType, RequiredProperties, RowCountHint, Single, Techempower, TopLevelStatements, and TsqlTips to reflect these changes. - Bumped version to 1.0.59 in version.json.
…eneric parameters
…d column skips - Updated interceptor methods across multiple files to replace foreach loops with for loops for better performance and clarity. - Changed return statements from null to tokenCount in Read methods to ensure proper handling of token counts. - Removed unnecessary comments regarding unmapped columns, streamlining the code. - Added new query methods (Query2 to Query5 and QueryAsync6 to QueryAsync11) to enhance multi-mapping capabilities for the Foo.Customer type. - Ensured all changes maintain the integrity of the Dapper.AOT functionality while improving readability and maintainability.
WIP: Partial implementation of multi-map query support (splitOn)
Author
|
I might've been a little too eager since I checked a little further and it seems not all data is coming back correctly. I'll dig into that a little further |
Author
|
Ok I fixed the last remaining issues. It should work now. |
…le should be null
Author
|
Ok I fixed more last remaining issues. It should work now 😄 |
… improve error messaging
Author
|
Okayyy... Now it's fixed... I think |
…n with Dapper's logic
Author
|
Ok I fixed one more thing with enums not working. That's also in this PR now. I've been trying to use the original Dapper as a reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Just like this issue I also needed support for SplitOn:
#163
I played quite a bit with AI for this PR but it seems to work for me at least. So please do a thorough review before merging this in.
Devedse