-
Notifications
You must be signed in to change notification settings - Fork 322
Add instrumentation tests for JUnit #10257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PerfectSlayer
wants to merge
3
commits into
master
Choose a base branch
from
bbujon/virtual-threads
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085866
Total [baseline] (8.823 s) : 0, 8823217
Agent [candidate] (1.088 s) : 0, 1088282
Total [candidate] (8.772 s) : 0, 8772107
section iast
Agent [baseline] (1.232 s) : 0, 1231681
Total [baseline] (9.348 s) : 0, 9347924
Agent [candidate] (1.224 s) : 0, 1223970
Total [candidate] (9.347 s) : 0, 9346598
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (651.764 ms) : 0, 651764
BytebuddyAgent [candidate] (653.838 ms) : 0, 653838
GlobalTracer [baseline] (283.773 ms) : 0, 283773
GlobalTracer [candidate] (284.372 ms) : 0, 284372
AppSec [baseline] (32.371 ms) : 0, 32371
AppSec [candidate] (32.561 ms) : 0, 32561
Debugger [baseline] (67.785 ms) : 0, 67785
Debugger [candidate] (67.306 ms) : 0, 67306
Remote Config [baseline] (633.319 µs) : 0, 633
Remote Config [candidate] (599.967 µs) : 0, 600
Telemetry [baseline] (9.061 ms) : 0, 9061
Telemetry [candidate] (9.021 ms) : 0, 9021
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.791 ms) : 0, 3791
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (797.252 ms) : 0, 797252
BytebuddyAgent [candidate] (792.37 ms) : 0, 792370
GlobalTracer [baseline] (257.011 ms) : 0, 257011
GlobalTracer [candidate] (256.12 ms) : 0, 256120
IAST [baseline] (27.204 ms) : 0, 27204
IAST [candidate] (26.986 ms) : 0, 26986
AppSec [baseline] (33.934 ms) : 0, 33934
AppSec [candidate] (30.764 ms) : 0, 30764
Debugger [baseline] (66.791 ms) : 0, 66791
Debugger [candidate] (68.571 ms) : 0, 68571
Remote Config [baseline] (602.398 µs) : 0, 602
Remote Config [candidate] (603.539 µs) : 0, 604
Telemetry [baseline] (8.54 ms) : 0, 8540
Telemetry [candidate] (8.414 ms) : 0, 8414
Flare Poller [baseline] (3.568 ms) : 0, 3568
Flare Poller [candidate] (3.499 ms) : 0, 3499
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089229
Total [baseline] (10.762 s) : 0, 10762011
Agent [candidate] (1.097 s) : 0, 1097324
Total [candidate] (10.888 s) : 0, 10887650
section appsec
Agent [baseline] (1.267 s) : 0, 1266858
Total [baseline] (11.077 s) : 0, 11076806
Agent [candidate] (1.275 s) : 0, 1275435
Total [candidate] (10.992 s) : 0, 10991833
section iast
Agent [baseline] (1.224 s) : 0, 1224217
Total [baseline] (11.193 s) : 0, 11192955
Agent [candidate] (1.24 s) : 0, 1239517
Total [candidate] (11.304 s) : 0, 11303990
section profiling
Agent [baseline] (1.204 s) : 0, 1203957
Total [baseline] (10.936 s) : 0, 10935736
Agent [candidate] (1.222 s) : 0, 1222230
Total [candidate] (11.0 s) : 0, 10999669
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (653.55 ms) : 0, 653550
BytebuddyAgent [candidate] (658.64 ms) : 0, 658640
GlobalTracer [baseline] (284.144 ms) : 0, 284144
GlobalTracer [candidate] (286.404 ms) : 0, 286404
AppSec [baseline] (32.62 ms) : 0, 32620
AppSec [candidate] (32.869 ms) : 0, 32869
Debugger [baseline] (68.917 ms) : 0, 68917
Debugger [candidate] (68.85 ms) : 0, 68850
Remote Config [baseline] (612.146 µs) : 0, 612
Remote Config [candidate] (643.325 µs) : 0, 643
Telemetry [baseline] (8.941 ms) : 0, 8941
Telemetry [candidate] (9.17 ms) : 0, 9170
Flare Poller [baseline] (3.684 ms) : 0, 3684
Flare Poller [candidate] (3.852 ms) : 0, 3852
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (690.733 ms) : 0, 690733
BytebuddyAgent [candidate] (697.144 ms) : 0, 697144
GlobalTracer [baseline] (259.066 ms) : 0, 259066
GlobalTracer [candidate] (261.35 ms) : 0, 261350
AppSec [baseline] (174.139 ms) : 0, 174139
AppSec [candidate] (175.26 ms) : 0, 175260
Debugger [baseline] (67.618 ms) : 0, 67618
Debugger [candidate] (66.449 ms) : 0, 66449
Remote Config [baseline] (761.333 µs) : 0, 761
Remote Config [candidate] (710.478 µs) : 0, 710
Telemetry [baseline] (9.25 ms) : 0, 9250
Telemetry [candidate] (9.033 ms) : 0, 9033
Flare Poller [baseline] (3.972 ms) : 0, 3972
Flare Poller [candidate] (3.759 ms) : 0, 3759
IAST [baseline] (24.614 ms) : 0, 24614
IAST [candidate] (24.816 ms) : 0, 24816
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (791.483 ms) : 0, 791483
BytebuddyAgent [candidate] (802.206 ms) : 0, 802206
GlobalTracer [baseline] (255.662 ms) : 0, 255662
GlobalTracer [candidate] (259.304 ms) : 0, 259304
AppSec [baseline] (32.702 ms) : 0, 32702
AppSec [candidate] (33.837 ms) : 0, 33837
Debugger [baseline] (68.048 ms) : 0, 68048
Debugger [candidate] (67.167 ms) : 0, 67167
Remote Config [baseline] (595.589 µs) : 0, 596
Remote Config [candidate] (589.243 µs) : 0, 589
Telemetry [baseline] (8.536 ms) : 0, 8536
Telemetry [candidate] (8.559 ms) : 0, 8559
Flare Poller [baseline] (3.498 ms) : 0, 3498
Flare Poller [candidate] (3.513 ms) : 0, 3513
IAST [baseline] (27.116 ms) : 0, 27116
IAST [candidate] (27.581 ms) : 0, 27581
section profiling
ProfilingAgent [baseline] (96.307 ms) : 0, 96307
ProfilingAgent [candidate] (97.285 ms) : 0, 97285
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.237 ms) : 0, 1237
BytebuddyAgent [baseline] (702.601 ms) : 0, 702601
BytebuddyAgent [candidate] (713.98 ms) : 0, 713980
GlobalTracer [baseline] (221.157 ms) : 0, 221157
GlobalTracer [candidate] (223.914 ms) : 0, 223914
AppSec [baseline] (32.019 ms) : 0, 32019
AppSec [candidate] (32.861 ms) : 0, 32861
Debugger [baseline] (67.95 ms) : 0, 67950
Debugger [candidate] (68.739 ms) : 0, 68739
Remote Config [baseline] (633.677 µs) : 0, 634
Remote Config [candidate] (642.585 µs) : 0, 643
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.837 ms) : 0, 8837
Flare Poller [baseline] (3.715 ms) : 0, 3715
Flare Poller [candidate] (3.729 ms) : 0, 3729
Profiling [baseline] (96.873 ms) : 0, 96873
Profiling [candidate] (97.879 ms) : 0, 97879
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section baseline
no_agent (1.169 ms) : 1157, 1180
. : milestone, 1169,
iast (3.179 ms) : 3137, 3221
. : milestone, 3179,
iast_FULL (5.67 ms) : 5614, 5726
. : milestone, 5670,
iast_GLOBAL (3.626 ms) : 3573, 3679
. : milestone, 3626,
profiling (2.172 ms) : 2150, 2194
. : milestone, 2172,
tracing (1.745 ms) : 1731, 1759
. : milestone, 1745,
section candidate
no_agent (1.195 ms) : 1183, 1206
. : milestone, 1195,
iast (3.263 ms) : 3217, 3309
. : milestone, 3263,
iast_FULL (5.979 ms) : 5918, 6041
. : milestone, 5979,
iast_GLOBAL (3.493 ms) : 3451, 3536
. : milestone, 3493,
profiling (1.861 ms) : 1846, 1876
. : milestone, 1861,
tracing (1.766 ms) : 1753, 1780
. : milestone, 1766,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section baseline
no_agent (19.379 ms) : 19182, 19576
. : milestone, 19379,
appsec (18.616 ms) : 18432, 18801
. : milestone, 18616,
code_origins (17.83 ms) : 17653, 18008
. : milestone, 17830,
iast (17.783 ms) : 17605, 17961
. : milestone, 17783,
profiling (18.52 ms) : 18333, 18708
. : milestone, 18520,
tracing (17.715 ms) : 17540, 17891
. : milestone, 17715,
section candidate
no_agent (18.219 ms) : 18031, 18407
. : milestone, 18219,
appsec (20.607 ms) : 20397, 20817
. : milestone, 20607,
code_origins (17.725 ms) : 17549, 17901
. : milestone, 17725,
iast (17.976 ms) : 17799, 18153
. : milestone, 17976,
profiling (18.729 ms) : 18540, 18917
. : milestone, 18729,
tracing (18.035 ms) : 17853, 18216
. : milestone, 18035,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.654 ms) : 3439, 3869
. : milestone, 3654,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.261 ms) : 2196, 2327
. : milestone, 2261,
profiling (2.099 ms) : 2045, 2153
. : milestone, 2099,
tracing (2.05 ms) : 1999, 2101
. : milestone, 2050,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.744 ms) : 3525, 3964
. : milestone, 3744,
iast (2.221 ms) : 2156, 2286
. : milestone, 2221,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.101 ms) : 2047, 2156
. : milestone, 2101,
tracing (2.052 ms) : 2000, 2103
. : milestone, 2052,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~dccd70aa36, baseline=1.58.0-SNAPSHOT~09f5899bc2
dateFormat X
axisFormat %s
section baseline
no_agent (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
appsec (14.658 s) : 14658000, 14658000
. : milestone, 14658000,
iast (18.317 s) : 18317000, 18317000
. : milestone, 18317000,
iast_GLOBAL (17.969 s) : 17969000, 17969000
. : milestone, 17969000,
profiling (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
tracing (14.497 s) : 14497000, 14497000
. : milestone, 14497000,
section candidate
no_agent (15.555 s) : 15555000, 15555000
. : milestone, 15555000,
appsec (14.508 s) : 14508000, 14508000
. : milestone, 14508000,
iast (17.949 s) : 17949000, 17949000
. : milestone, 17949000,
iast_GLOBAL (17.922 s) : 17922000, 17922000
. : milestone, 17922000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (14.614 s) : 14614000, 14614000
. : milestone, 14614000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
DRAFT. Sharing early work about JUnit assert rules related to tracing and instrumented tests.
Those API are experimental only and
AbstractInstrumentationTestmight be reworked as an extension in a near feature.Motivation
Sharing to prevent code publication and conflict.
Additional Notes
Work based on 2024Q4 R&D week results
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]