-
Notifications
You must be signed in to change notification settings - Fork 322
Allow ddprof version override to build a custom 'profiler-snapshot' dd-java-agent artifact #10265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow ddprof version override to build a custom 'profiler-snapshot' dd-java-agent artifact #10265
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089910
Total [baseline] (8.717 s) : 0, 8717331
Agent [candidate] (1.094 s) : 0, 1093707
Total [candidate] (8.759 s) : 0, 8758599
section iast
Agent [baseline] (1.224 s) : 0, 1224331
Total [baseline] (9.301 s) : 0, 9301060
Agent [candidate] (1.233 s) : 0, 1233333
Total [candidate] (9.294 s) : 0, 9294009
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (657.226 ms) : 0, 657226
BytebuddyAgent [candidate] (657.539 ms) : 0, 657539
GlobalTracer [baseline] (282.167 ms) : 0, 282167
GlobalTracer [candidate] (283.983 ms) : 0, 283983
AppSec [baseline] (32.694 ms) : 0, 32694
AppSec [candidate] (32.97 ms) : 0, 32970
Debugger [baseline] (67.614 ms) : 0, 67614
Debugger [candidate] (68.649 ms) : 0, 68649
Remote Config [baseline] (627.785 µs) : 0, 628
Remote Config [candidate] (621.833 µs) : 0, 622
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (9.231 ms) : 0, 9231
Flare Poller [baseline] (3.759 ms) : 0, 3759
Flare Poller [candidate] (3.849 ms) : 0, 3849
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (792.878 ms) : 0, 792878
BytebuddyAgent [candidate] (800.616 ms) : 0, 800616
GlobalTracer [baseline] (255.264 ms) : 0, 255264
GlobalTracer [candidate] (256.248 ms) : 0, 256248
IAST [baseline] (27.057 ms) : 0, 27057
IAST [candidate] (27.196 ms) : 0, 27196
AppSec [baseline] (31.664 ms) : 0, 31664
AppSec [candidate] (33.737 ms) : 0, 33737
Debugger [baseline] (68.417 ms) : 0, 68417
Debugger [candidate] (66.065 ms) : 0, 66065
Remote Config [baseline] (585.592 µs) : 0, 586
Remote Config [candidate] (576.649 µs) : 0, 577
Telemetry [baseline] (8.438 ms) : 0, 8438
Telemetry [candidate] (8.498 ms) : 0, 8498
Flare Poller [baseline] (3.473 ms) : 0, 3473
Flare Poller [candidate] (3.494 ms) : 0, 3494
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083576
Total [baseline] (10.768 s) : 0, 10768241
Agent [candidate] (1.091 s) : 0, 1090609
Total [candidate] (10.767 s) : 0, 10766723
section appsec
Agent [baseline] (1.262 s) : 0, 1261736
Total [baseline] (10.936 s) : 0, 10935585
Agent [candidate] (1.282 s) : 0, 1281990
Total [candidate] (10.926 s) : 0, 10926283
section iast
Agent [baseline] (1.247 s) : 0, 1246550
Total [baseline] (11.299 s) : 0, 11299426
Agent [candidate] (1.23 s) : 0, 1229622
Total [candidate] (11.134 s) : 0, 11134487
section profiling
Agent [baseline] (1.204 s) : 0, 1204180
Total [baseline] (10.911 s) : 0, 10911403
Agent [candidate] (1.205 s) : 0, 1205168
Total [candidate] (10.911 s) : 0, 10911367
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (650.787 ms) : 0, 650787
BytebuddyAgent [candidate] (656.911 ms) : 0, 656911
GlobalTracer [baseline] (282.298 ms) : 0, 282298
GlobalTracer [candidate] (282.75 ms) : 0, 282750
AppSec [baseline] (32.482 ms) : 0, 32482
AppSec [candidate] (32.507 ms) : 0, 32507
Debugger [baseline] (67.994 ms) : 0, 67994
Debugger [candidate] (68.117 ms) : 0, 68117
Remote Config [baseline] (618.313 µs) : 0, 618
Remote Config [candidate] (618.854 µs) : 0, 619
Telemetry [baseline] (9.064 ms) : 0, 9064
Telemetry [candidate] (9.083 ms) : 0, 9083
Flare Poller [baseline] (3.731 ms) : 0, 3731
Flare Poller [candidate] (3.756 ms) : 0, 3756
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (689.799 ms) : 0, 689799
BytebuddyAgent [candidate] (701.999 ms) : 0, 701999
GlobalTracer [baseline] (256.666 ms) : 0, 256666
GlobalTracer [candidate] (261.042 ms) : 0, 261042
IAST [baseline] (24.473 ms) : 0, 24473
IAST [candidate] (25.085 ms) : 0, 25085
AppSec [baseline] (173.625 ms) : 0, 173625
AppSec [candidate] (175.436 ms) : 0, 175436
Debugger [baseline] (66.672 ms) : 0, 66672
Debugger [candidate] (67.745 ms) : 0, 67745
Remote Config [baseline] (777.543 µs) : 0, 778
Remote Config [candidate] (785.17 µs) : 0, 785
Telemetry [baseline] (9.581 ms) : 0, 9581
Telemetry [candidate] (9.42 ms) : 0, 9420
Flare Poller [baseline] (3.718 ms) : 0, 3718
Flare Poller [candidate] (3.645 ms) : 0, 3645
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (807.811 ms) : 0, 807811
BytebuddyAgent [candidate] (795.895 ms) : 0, 795895
GlobalTracer [baseline] (259.702 ms) : 0, 259702
GlobalTracer [candidate] (256.431 ms) : 0, 256431
IAST [baseline] (27.732 ms) : 0, 27732
IAST [candidate] (27.443 ms) : 0, 27443
AppSec [baseline] (33.868 ms) : 0, 33868
AppSec [candidate] (35.177 ms) : 0, 35177
Debugger [baseline] (67.62 ms) : 0, 67620
Debugger [candidate] (65.453 ms) : 0, 65453
Remote Config [baseline] (592.832 µs) : 0, 593
Remote Config [candidate] (601.117 µs) : 0, 601
Telemetry [baseline] (8.655 ms) : 0, 8655
Telemetry [candidate] (8.568 ms) : 0, 8568
Flare Poller [baseline] (3.544 ms) : 0, 3544
Flare Poller [candidate] (3.485 ms) : 0, 3485
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (703.706 ms) : 0, 703706
BytebuddyAgent [candidate] (704.398 ms) : 0, 704398
GlobalTracer [baseline] (220.217 ms) : 0, 220217
GlobalTracer [candidate] (219.881 ms) : 0, 219881
AppSec [baseline] (32.094 ms) : 0, 32094
AppSec [candidate] (32.008 ms) : 0, 32008
Debugger [baseline] (67.849 ms) : 0, 67849
Debugger [candidate] (67.687 ms) : 0, 67687
Remote Config [baseline] (654.006 µs) : 0, 654
Remote Config [candidate] (636.964 µs) : 0, 637
Telemetry [baseline] (8.721 ms) : 0, 8721
Telemetry [candidate] (8.829 ms) : 0, 8829
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.749 ms) : 0, 3749
ProfilingAgent [baseline] (96.266 ms) : 0, 96266
ProfilingAgent [candidate] (96.85 ms) : 0, 96850
Profiling [baseline] (96.857 ms) : 0, 96857
Profiling [candidate] (97.423 ms) : 0, 97423
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.175 ms) : 3131, 3218
. : milestone, 3175,
iast_FULL (5.799 ms) : 5742, 5856
. : milestone, 5799,
iast_GLOBAL (3.593 ms) : 3540, 3645
. : milestone, 3593,
profiling (2.007 ms) : 1989, 2024
. : milestone, 2007,
tracing (1.815 ms) : 1800, 1830
. : milestone, 1815,
section candidate
no_agent (1.224 ms) : 1211, 1236
. : milestone, 1224,
iast (3.217 ms) : 3175, 3260
. : milestone, 3217,
iast_FULL (5.806 ms) : 5749, 5863
. : milestone, 5806,
iast_GLOBAL (3.549 ms) : 3498, 3600
. : milestone, 3549,
profiling (2.096 ms) : 2073, 2118
. : milestone, 2096,
tracing (1.8 ms) : 1784, 1815
. : milestone, 1800,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (17.081 ms) : 16910, 17251
. : milestone, 17081,
appsec (18.655 ms) : 18465, 18844
. : milestone, 18655,
code_origins (17.987 ms) : 17807, 18167
. : milestone, 17987,
iast (18.025 ms) : 17845, 18205
. : milestone, 18025,
profiling (18.87 ms) : 18680, 19060
. : milestone, 18870,
tracing (17.847 ms) : 17669, 18025
. : milestone, 17847,
section candidate
no_agent (18.799 ms) : 18608, 18989
. : milestone, 18799,
appsec (18.878 ms) : 18684, 19073
. : milestone, 18878,
code_origins (17.755 ms) : 17574, 17936
. : milestone, 17755,
iast (17.801 ms) : 17627, 17975
. : milestone, 17801,
profiling (18.907 ms) : 18719, 19094
. : milestone, 18907,
tracing (17.985 ms) : 17807, 18164
. : milestone, 17985,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.657 ms) : 3441, 3873
. : milestone, 3657,
iast (2.233 ms) : 2168, 2299
. : milestone, 2233,
iast_GLOBAL (2.272 ms) : 2206, 2338
. : milestone, 2272,
profiling (2.112 ms) : 2057, 2167
. : milestone, 2112,
tracing (2.056 ms) : 2005, 2107
. : milestone, 2056,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.68 ms) : 3464, 3896
. : milestone, 3680,
iast (2.237 ms) : 2172, 2303
. : milestone, 2237,
iast_GLOBAL (2.267 ms) : 2202, 2332
. : milestone, 2267,
profiling (2.079 ms) : 2025, 2132
. : milestone, 2079,
tracing (2.059 ms) : 2008, 2109
. : milestone, 2059,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~1445ba8a5d, baseline=1.58.0-SNAPSHOT~a69554eb6e
dateFormat X
axisFormat %s
section baseline
no_agent (15.644 s) : 15644000, 15644000
. : milestone, 15644000,
appsec (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
iast (18.131 s) : 18131000, 18131000
. : milestone, 18131000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
. : milestone, 17872000,
profiling (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
tracing (14.453 s) : 14453000, 14453000
. : milestone, 14453000,
section candidate
no_agent (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
appsec (14.36 s) : 14360000, 14360000
. : milestone, 14360000,
iast (18.662 s) : 18662000, 18662000
. : milestone, 18662000,
iast_GLOBAL (18.079 s) : 18079000, 18079000
. : milestone, 18079000,
profiling (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
tracing (14.756 s) : 14756000, 14756000
. : milestone, 14756000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
This PR adds the ability to 'override' the ddprof (Java Profiler) dependency with its current snapshot version.
This is done by adding
-PddprofSnapshotVersionto the gradle task arguments.Motivation
We (the Java profiler team) are looking for faster dogfooding iteration which involves the complete integration of the profiler library to the tracer. This is the first, preparatory step in order to be able to do that regularly in the future.
Additional Notes
This change is not affecting anything else and it is completely optional to use.
The CI job is manually triggered only for now.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue