-
Notifications
You must be signed in to change notification settings - Fork 323
Allow running wallclock profiler even without tracer #10298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079850
Total [baseline] (8.749 s) : 0, 8749301
Agent [candidate] (1.084 s) : 0, 1083524
Total [candidate] (8.755 s) : 0, 8754937
section iast
Agent [baseline] (1.232 s) : 0, 1232484
Total [baseline] (9.384 s) : 0, 9383552
Agent [candidate] (1.231 s) : 0, 1231389
Total [candidate] (9.327 s) : 0, 9327055
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (647.775 ms) : 0, 647775
BytebuddyAgent [candidate] (650.576 ms) : 0, 650576
GlobalTracer [baseline] (281.325 ms) : 0, 281325
GlobalTracer [candidate] (282.71 ms) : 0, 282710
AppSec [baseline] (32.434 ms) : 0, 32434
AppSec [candidate] (32.62 ms) : 0, 32620
Debugger [baseline] (68.57 ms) : 0, 68570
Debugger [candidate] (67.755 ms) : 0, 67755
Remote Config [baseline] (627.342 µs) : 0, 627
Remote Config [candidate] (633.939 µs) : 0, 634
Telemetry [baseline] (8.799 ms) : 0, 8799
Telemetry [candidate] (8.914 ms) : 0, 8914
Flare Poller [baseline] (3.658 ms) : 0, 3658
Flare Poller [candidate] (3.694 ms) : 0, 3694
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (797.055 ms) : 0, 797055
BytebuddyAgent [candidate] (797.145 ms) : 0, 797145
GlobalTracer [baseline] (257.499 ms) : 0, 257499
GlobalTracer [candidate] (257.385 ms) : 0, 257385
AppSec [baseline] (35.023 ms) : 0, 35023
AppSec [candidate] (33.894 ms) : 0, 33894
Debugger [baseline] (65.958 ms) : 0, 65958
Debugger [candidate] (66.209 ms) : 0, 66209
Remote Config [baseline] (568.773 µs) : 0, 569
Remote Config [candidate] (593.869 µs) : 0, 594
Telemetry [baseline] (8.559 ms) : 0, 8559
Telemetry [candidate] (8.601 ms) : 0, 8601
Flare Poller [baseline] (3.619 ms) : 0, 3619
Flare Poller [candidate] (3.622 ms) : 0, 3622
IAST [baseline] (27.336 ms) : 0, 27336
IAST [candidate] (27.16 ms) : 0, 27160
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098380
Total [baseline] (10.935 s) : 0, 10935396
Agent [candidate] (1.083 s) : 0, 1083207
Total [candidate] (10.87 s) : 0, 10870417
section appsec
Agent [baseline] (1.266 s) : 0, 1265891
Total [baseline] (10.947 s) : 0, 10947332
Agent [candidate] (1.265 s) : 0, 1264514
Total [candidate] (11.082 s) : 0, 11081851
section iast
Agent [baseline] (1.224 s) : 0, 1224326
Total [baseline] (11.23 s) : 0, 11229613
Agent [candidate] (1.223 s) : 0, 1223042
Total [candidate] (11.123 s) : 0, 11123139
section profiling
Agent [baseline] (1.21 s) : 0, 1210383
Total [baseline] (10.946 s) : 0, 10946076
Agent [candidate] (1.207 s) : 0, 1207004
Total [candidate] (10.929 s) : 0, 10929356
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (659.741 ms) : 0, 659741
BytebuddyAgent [candidate] (649.764 ms) : 0, 649764
GlobalTracer [baseline] (285.597 ms) : 0, 285597
GlobalTracer [candidate] (282.407 ms) : 0, 282407
AppSec [baseline] (33.12 ms) : 0, 33120
AppSec [candidate] (32.514 ms) : 0, 32514
Debugger [baseline] (69.31 ms) : 0, 69310
Debugger [candidate] (67.744 ms) : 0, 67744
Remote Config [baseline] (635.504 µs) : 0, 636
Remote Config [candidate] (612.209 µs) : 0, 612
Telemetry [baseline] (9.077 ms) : 0, 9077
Telemetry [candidate] (9.88 ms) : 0, 9880
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.694 ms) : 0, 3694
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (690.292 ms) : 0, 690292
BytebuddyAgent [candidate] (690.056 ms) : 0, 690056
GlobalTracer [baseline] (258.039 ms) : 0, 258039
GlobalTracer [candidate] (257.955 ms) : 0, 257955
AppSec [baseline] (173.04 ms) : 0, 173040
AppSec [candidate] (173.917 ms) : 0, 173917
Debugger [baseline] (69.226 ms) : 0, 69226
Debugger [candidate] (67.448 ms) : 0, 67448
Remote Config [baseline] (785.077 µs) : 0, 785
Remote Config [candidate] (760.017 µs) : 0, 760
Telemetry [baseline] (9.561 ms) : 0, 9561
Telemetry [candidate] (9.472 ms) : 0, 9472
Flare Poller [baseline] (3.817 ms) : 0, 3817
Flare Poller [candidate] (3.805 ms) : 0, 3805
IAST [baseline] (24.441 ms) : 0, 24441
IAST [candidate] (24.58 ms) : 0, 24580
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (791.961 ms) : 0, 791961
BytebuddyAgent [candidate] (790.533 ms) : 0, 790533
GlobalTracer [baseline] (256.257 ms) : 0, 256257
GlobalTracer [candidate] (256.143 ms) : 0, 256143
AppSec [baseline] (34.151 ms) : 0, 34151
AppSec [candidate] (35.442 ms) : 0, 35442
Debugger [baseline] (65.455 ms) : 0, 65455
Debugger [candidate] (64.729 ms) : 0, 64729
Remote Config [baseline] (609.864 µs) : 0, 610
Remote Config [candidate] (598.831 µs) : 0, 599
Telemetry [baseline] (8.539 ms) : 0, 8539
Telemetry [candidate] (8.456 ms) : 0, 8456
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.587 ms) : 0, 3587
IAST [baseline] (27.127 ms) : 0, 27127
IAST [candidate] (26.923 ms) : 0, 26923
section profiling
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (706.638 ms) : 0, 706638
BytebuddyAgent [candidate] (703.916 ms) : 0, 703916
GlobalTracer [baseline] (221.621 ms) : 0, 221621
GlobalTracer [candidate] (220.702 ms) : 0, 220702
AppSec [baseline] (32.356 ms) : 0, 32356
AppSec [candidate] (32.135 ms) : 0, 32135
Debugger [baseline] (67.97 ms) : 0, 67970
Debugger [candidate] (68.176 ms) : 0, 68176
Remote Config [baseline] (635.654 µs) : 0, 636
Remote Config [candidate] (619.403 µs) : 0, 619
Telemetry [baseline] (8.772 ms) : 0, 8772
Telemetry [candidate] (8.731 ms) : 0, 8731
Flare Poller [baseline] (3.645 ms) : 0, 3645
Flare Poller [candidate] (3.701 ms) : 0, 3701
ProfilingAgent [baseline] (97.432 ms) : 0, 97432
ProfilingAgent [candidate] (97.895 ms) : 0, 97895
Profiling [baseline] (98.002 ms) : 0, 98002
Profiling [candidate] (98.477 ms) : 0, 98477
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1175, 1197
. : milestone, 1186,
iast (3.154 ms) : 3109, 3200
. : milestone, 3154,
iast_FULL (5.819 ms) : 5760, 5879
. : milestone, 5819,
iast_GLOBAL (3.592 ms) : 3532, 3652
. : milestone, 3592,
profiling (2.013 ms) : 1996, 2031
. : milestone, 2013,
tracing (1.847 ms) : 1832, 1863
. : milestone, 1847,
section candidate
no_agent (1.171 ms) : 1160, 1182
. : milestone, 1171,
iast (3.101 ms) : 3060, 3143
. : milestone, 3101,
iast_FULL (5.852 ms) : 5793, 5910
. : milestone, 5852,
iast_GLOBAL (3.571 ms) : 3514, 3629
. : milestone, 3571,
profiling (1.99 ms) : 1973, 2006
. : milestone, 1990,
tracing (1.8 ms) : 1785, 1814
. : milestone, 1800,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (19.508 ms) : 19302, 19713
. : milestone, 19508,
appsec (18.561 ms) : 18374, 18748
. : milestone, 18561,
code_origins (17.808 ms) : 17631, 17985
. : milestone, 17808,
iast (18.881 ms) : 18693, 19068
. : milestone, 18881,
profiling (19.685 ms) : 19484, 19886
. : milestone, 19685,
tracing (17.838 ms) : 17659, 18016
. : milestone, 17838,
section candidate
no_agent (18.333 ms) : 18144, 18521
. : milestone, 18333,
appsec (19.007 ms) : 18815, 19200
. : milestone, 19007,
code_origins (17.702 ms) : 17529, 17876
. : milestone, 17702,
iast (17.647 ms) : 17469, 17824
. : milestone, 17647,
profiling (18.685 ms) : 18497, 18873
. : milestone, 18685,
tracing (17.63 ms) : 17456, 17804
. : milestone, 17630,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.517 ms) : 2462, 2572
. : milestone, 2517,
iast (2.222 ms) : 2157, 2287
. : milestone, 2222,
iast_GLOBAL (2.249 ms) : 2184, 2314
. : milestone, 2249,
profiling (2.071 ms) : 2018, 2124
. : milestone, 2071,
tracing (2.057 ms) : 2005, 2109
. : milestone, 2057,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.745 ms) : 3524, 3965
. : milestone, 3745,
iast (2.223 ms) : 2158, 2288
. : milestone, 2223,
iast_GLOBAL (2.259 ms) : 2194, 2325
. : milestone, 2259,
profiling (2.065 ms) : 2013, 2118
. : milestone, 2065,
tracing (2.047 ms) : 1996, 2098
. : milestone, 2047,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~a5f0d365b9, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (15.534 s) : 15534000, 15534000
. : milestone, 15534000,
appsec (14.894 s) : 14894000, 14894000
. : milestone, 14894000,
iast (17.995 s) : 17995000, 17995000
. : milestone, 17995000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
tracing (14.523 s) : 14523000, 14523000
. : milestone, 14523000,
section candidate
no_agent (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
appsec (14.536 s) : 14536000, 14536000
. : milestone, 14536000,
iast (18.099 s) : 18099000, 18099000
. : milestone, 18099000,
iast_GLOBAL (18.014 s) : 18014000, 18014000
. : milestone, 18014000,
profiling (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
tracing (14.54 s) : 14540000, 14540000
. : milestone, 14540000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
6997fe7 to
a5f0d36
Compare
What Does This Do
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
Motivation
There are users that want to run profiler without tracer (sic). For those, the wallclock profiling is not possible, ATM. This is fixing that gap.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-13347