🪞 10269 - Feature: CICS tracing #10301

mcculls · 2026-01-07T10:42:30Z

This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.

Original PR: #10269
Original Author: @deejgregor
Original Branch: deejgregor/dd-trace-java:feature-cics-tracing

Closes #10269

This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.

- ECIInteraction.execute -- instruments the entry point for CICS calls via IBM's javax.resource.cci.Interaction implementation, creating "cics.execute" span and recording a few tags. - JavaGatewayInstrumentation.flow -- records the peer.* tags on the "cics.execute" span created above, or if it doesn't exist, creates a new "gateway.flow" span. The tests don't fully exercise the CICS client-side code, however they exercise enough to ensure the instrumentation creates spans and adds tags as expected. This requires a few JAR files from IBM's CICS SDK for compliation and testing that are not available in Maven Central. A tar.gz artifact is downloaded from IBM's public CICS support archive and the necessary JARs are extracted, following the same pattern used for the JBoss Wildfly smoke tests.

pr-commenter · 2026-01-07T11:29:55Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	community-pr-10269
git_commit_date	1767720455	1767860050
git_commit_sha	`92c84e2`	`47d95f9`
release_version	1.59.0-SNAPSHOT~92c84e28db	1.59.0-SNAPSHOT~47d95f97ec

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1767862123	1767862123
ci_job_id	1335193684	1335193684
ci_pipeline_id	89620816	89620816
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-k3llicm2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-k3llicm2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087724
Total [baseline] (10.795 s) : 0, 10794677
Agent [candidate] (1.095 s) : 0, 1094814
Total [candidate] (10.76 s) : 0, 10760416
section appsec
Agent [baseline] (1.266 s) : 0, 1265848
Total [baseline] (10.987 s) : 0, 10987092
Agent [candidate] (1.27 s) : 0, 1269932
Total [candidate] (11.089 s) : 0, 11088831
section iast
Agent [baseline] (1.225 s) : 0, 1224645
Total [baseline] (11.134 s) : 0, 11134117
Agent [candidate] (1.225 s) : 0, 1225232
Total [candidate] (11.177 s) : 0, 11176566
section profiling
Agent [baseline] (1.209 s) : 0, 1209391
Total [baseline] (10.932 s) : 0, 10932458
Agent [candidate] (1.206 s) : 0, 1205850
Total [candidate] (11.001 s) : 0, 11001120

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.266 s	178.125 ms (16.4%)
Agent	iast	1.225 s	136.921 ms (12.6%)
Agent	profiling	1.209 s	121.667 ms (11.2%)
Total	tracing	10.795 s	-
Total	appsec	10.987 s	192.415 ms (1.8%)
Total	iast	11.134 s	339.44 ms (3.1%)
Total	profiling	10.932 s	137.78 ms (1.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.27 s	175.118 ms (16.0%)
Agent	iast	1.225 s	130.418 ms (11.9%)
Agent	profiling	1.206 s	111.036 ms (10.1%)
Total	tracing	10.76 s	-
Total	appsec	11.089 s	328.415 ms (3.1%)
Total	iast	11.177 s	416.15 ms (3.9%)
Total	profiling	11.001 s	240.704 ms (2.2%)

gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (652.691 ms) : 0, 652691
BytebuddyAgent [candidate] (657.495 ms) : 0, 657495
GlobalTracer [baseline] (283.435 ms) : 0, 283435
GlobalTracer [candidate] (284.931 ms) : 0, 284931
AppSec [baseline] (32.666 ms) : 0, 32666
AppSec [candidate] (33.012 ms) : 0, 33012
Debugger [baseline] (68.569 ms) : 0, 68569
Debugger [candidate] (68.89 ms) : 0, 68890
Remote Config [baseline] (640.296 µs) : 0, 640
Remote Config [candidate] (632.223 µs) : 0, 632
Telemetry [baseline] (9.069 ms) : 0, 9069
Telemetry [candidate] (9.065 ms) : 0, 9065
Flare Poller [baseline] (3.755 ms) : 0, 3755
Flare Poller [candidate] (3.833 ms) : 0, 3833
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (690.798 ms) : 0, 690798
BytebuddyAgent [candidate] (694.002 ms) : 0, 694002
GlobalTracer [baseline] (258.572 ms) : 0, 258572
GlobalTracer [candidate] (259.291 ms) : 0, 259291
AppSec [baseline] (173.741 ms) : 0, 173741
AppSec [candidate] (174.66 ms) : 0, 174660
Debugger [baseline] (67.783 ms) : 0, 67783
Debugger [candidate] (66.685 ms) : 0, 66685
Remote Config [baseline] (753.506 µs) : 0, 754
Remote Config [candidate] (734.487 µs) : 0, 734
Telemetry [baseline] (9.314 ms) : 0, 9314
Telemetry [candidate] (9.357 ms) : 0, 9357
Flare Poller [baseline] (3.751 ms) : 0, 3751
Flare Poller [candidate] (3.821 ms) : 0, 3821
IAST [baseline] (24.444 ms) : 0, 24444
IAST [candidate] (24.661 ms) : 0, 24661
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (791.5 ms) : 0, 791500
BytebuddyAgent [candidate] (792.198 ms) : 0, 792198
GlobalTracer [baseline] (256.562 ms) : 0, 256562
GlobalTracer [candidate] (256.241 ms) : 0, 256241
AppSec [baseline] (32.577 ms) : 0, 32577
AppSec [candidate] (35.54 ms) : 0, 35540
Debugger [baseline] (67.666 ms) : 0, 67666
Debugger [candidate] (64.73 ms) : 0, 64730
Remote Config [baseline] (550.917 µs) : 0, 551
Remote Config [candidate] (583.967 µs) : 0, 584
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.546 ms) : 0, 8546
Flare Poller [baseline] (3.591 ms) : 0, 3591
Flare Poller [candidate] (3.518 ms) : 0, 3518
IAST [baseline] (27.073 ms) : 0, 27073
IAST [candidate] (27.157 ms) : 0, 27157
section profiling
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (706.14 ms) : 0, 706140
BytebuddyAgent [candidate] (703.813 ms) : 0, 703813
GlobalTracer [baseline] (220.769 ms) : 0, 220769
GlobalTracer [candidate] (220.815 ms) : 0, 220815
AppSec [baseline] (32.218 ms) : 0, 32218
AppSec [candidate] (32.296 ms) : 0, 32296
Debugger [baseline] (68.028 ms) : 0, 68028
Debugger [candidate] (67.561 ms) : 0, 67561
Remote Config [baseline] (657.207 µs) : 0, 657
Remote Config [candidate] (643.578 µs) : 0, 644
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.731 ms) : 0, 8731
Flare Poller [baseline] (3.665 ms) : 0, 3665
Flare Poller [candidate] (3.678 ms) : 0, 3678
ProfilingAgent [baseline] (97.613 ms) : 0, 97613
ProfilingAgent [candidate] (97.251 ms) : 0, 97251
Profiling [baseline] (98.197 ms) : 0, 98197
Profiling [candidate] (97.826 ms) : 0, 97826

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088868
Total [baseline] (8.769 s) : 0, 8768588
Agent [candidate] (1.087 s) : 0, 1086889
Total [candidate] (8.79 s) : 0, 8790263
section iast
Agent [baseline] (1.233 s) : 0, 1233368
Total [baseline] (9.452 s) : 0, 9451734
Agent [candidate] (1.221 s) : 0, 1221254
Total [candidate] (9.328 s) : 0, 9328464

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	iast	1.233 s	144.5 ms (13.3%)
Total	tracing	8.769 s	-
Total	iast	9.452 s	683.146 ms (7.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.087 s	-
Agent	iast	1.221 s	134.365 ms (12.4%)
Total	tracing	8.79 s	-
Total	iast	9.328 s	538.201 ms (6.1%)

gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (653.262 ms) : 0, 653262
BytebuddyAgent [candidate] (652.535 ms) : 0, 652535
GlobalTracer [baseline] (284.363 ms) : 0, 284363
GlobalTracer [candidate] (283.14 ms) : 0, 283140
AppSec [baseline] (33.006 ms) : 0, 33006
AppSec [candidate] (32.764 ms) : 0, 32764
Debugger [baseline] (68.1 ms) : 0, 68100
Debugger [candidate] (68.202 ms) : 0, 68202
Remote Config [baseline] (635.758 µs) : 0, 636
Remote Config [candidate] (631.086 µs) : 0, 631
Telemetry [baseline] (8.935 ms) : 0, 8935
Telemetry [candidate] (9.049 ms) : 0, 9049
Flare Poller [baseline] (3.707 ms) : 0, 3707
Flare Poller [candidate] (3.773 ms) : 0, 3773
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (797.749 ms) : 0, 797749
BytebuddyAgent [candidate] (789.398 ms) : 0, 789398
GlobalTracer [baseline] (257.722 ms) : 0, 257722
GlobalTracer [candidate] (255.559 ms) : 0, 255559
AppSec [baseline] (33.504 ms) : 0, 33504
AppSec [candidate] (32.983 ms) : 0, 32983
Debugger [baseline] (67.315 ms) : 0, 67315
Debugger [candidate] (66.717 ms) : 0, 66717
Remote Config [baseline] (599.779 µs) : 0, 600
Remote Config [candidate] (608.054 µs) : 0, 608
Telemetry [baseline] (8.521 ms) : 0, 8521
Telemetry [candidate] (8.554 ms) : 0, 8554
Flare Poller [baseline] (3.639 ms) : 0, 3639
Flare Poller [candidate] (3.481 ms) : 0, 3481
IAST [baseline] (27.43 ms) : 0, 27430
IAST [candidate] (27.268 ms) : 0, 27268

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	community-pr-10269
git_commit_date	1767720455	1767860050
git_commit_sha	`92c84e2`	`47d95f9`
release_version	1.59.0-SNAPSHOT~92c84e28db	1.59.0-SNAPSHOT~47d95f97ec

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1767862650	1767862650
ci_job_id	1335193686	1335193686
ci_pipeline_id	89620816	89620816
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-5dfryjls 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-5dfryjls 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast:high_load	worse [+56.677µs; +142.889µs] or [+2.258%; +5.694%]	unsure [+53.232µs; +428.183µs] or [+0.723%; +5.819%]	unstable [-194.019op/s; +95.206op/s] or [-13.705%; +6.725%]	2.609ms	7.599ms	1366.312op/s	2.510ms	7.358ms	1415.719op/s
scenario:load:petclinic:profiling:high_load	worse [+0.628ms; +1.542ms] or [+3.410%; +8.367%]	same [-663.442µs; +1015.340µs] or [-2.162%; +3.308%]	unstable [-37.617op/s; +14.680op/s] or [-15.189%; +5.927%]	19.509ms	30.867ms	236.188op/s	18.424ms	30.691ms	247.656op/s
scenario:load:petclinic:no_agent:high_load	better [-2.584ms; -1.581ms] or [-13.658%; -8.360%]	better [-3.389ms; -1.177ms] or [-11.000%; -3.820%]	unstable [-2.123op/s; +53.248op/s] or [-0.876%; +21.983%]	16.834ms	28.526ms	267.781op/s	18.917ms	30.808ms	242.219op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.193 ms) : 1182, 1205
.   : milestone, 1193,
iast (3.232 ms) : 3187, 3277
.   : milestone, 3232,
iast_FULL (5.904 ms) : 5845, 5964
.   : milestone, 5904,
iast_GLOBAL (3.593 ms) : 3533, 3653
.   : milestone, 3593,
profiling (2.023 ms) : 2005, 2041
.   : milestone, 2023,
tracing (1.808 ms) : 1793, 1824
.   : milestone, 1808,
section candidate
no_agent (1.211 ms) : 1198, 1224
.   : milestone, 1211,
iast (3.357 ms) : 3308, 3405
.   : milestone, 3357,
iast_FULL (5.938 ms) : 5877, 5998
.   : milestone, 5938,
iast_GLOBAL (3.677 ms) : 3621, 3733
.   : milestone, 3677,
profiling (2.093 ms) : 2073, 2112
.   : milestone, 2093,
tracing (1.805 ms) : 1790, 1819
.   : milestone, 1805,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.193 ms [1.182 ms, 1.205 ms]	-
iast	3.232 ms [3.187 ms, 3.277 ms]	2.039 ms (170.8%)
iast_FULL	5.904 ms [5.845 ms, 5.964 ms]	4.711 ms (394.7%)
iast_GLOBAL	3.593 ms [3.533 ms, 3.653 ms]	2.4 ms (201.1%)
profiling	2.023 ms [2.005 ms, 2.041 ms]	829.39 µs (69.5%)
tracing	1.808 ms [1.793 ms, 1.824 ms]	614.782 µs (51.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.211 ms [1.198 ms, 1.224 ms]	-
iast	3.357 ms [3.308 ms, 3.405 ms]	2.146 ms (177.2%)
iast_FULL	5.938 ms [5.877 ms, 5.998 ms]	4.727 ms (390.3%)
iast_GLOBAL	3.677 ms [3.621 ms, 3.733 ms]	2.466 ms (203.6%)
profiling	2.093 ms [2.073 ms, 2.112 ms]	881.693 µs (72.8%)
tracing	1.805 ms [1.79 ms, 1.819 ms]	593.612 µs (49.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.27 ms) : 19078, 19462
.   : milestone, 19270,
appsec (18.556 ms) : 18372, 18740
.   : milestone, 18556,
code_origins (17.947 ms) : 17769, 18124
.   : milestone, 17947,
iast (17.93 ms) : 17751, 18109
.   : milestone, 17930,
profiling (18.849 ms) : 18655, 19043
.   : milestone, 18849,
tracing (17.529 ms) : 17359, 17699
.   : milestone, 17529,
section candidate
no_agent (17.427 ms) : 17253, 17601
.   : milestone, 17427,
appsec (18.891 ms) : 18702, 19081
.   : milestone, 18891,
code_origins (17.802 ms) : 17625, 17979
.   : milestone, 17802,
iast (17.934 ms) : 17754, 18114
.   : milestone, 17934,
profiling (19.765 ms) : 19563, 19966
.   : milestone, 19765,
tracing (17.744 ms) : 17569, 17919
.   : milestone, 17744,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.27 ms [19.078 ms, 19.462 ms]	-
appsec	18.556 ms [18.372 ms, 18.74 ms]	-714.191 µs (-3.7%)
code_origins	17.947 ms [17.769 ms, 18.124 ms]	-1.323 ms (-6.9%)
iast	17.93 ms [17.751 ms, 18.109 ms]	-1.34 ms (-7.0%)
profiling	18.849 ms [18.655 ms, 19.043 ms]	-420.848 µs (-2.2%)
tracing	17.529 ms [17.359 ms, 17.699 ms]	-1.741 ms (-9.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.427 ms [17.253 ms, 17.601 ms]	-
appsec	18.891 ms [18.702 ms, 19.081 ms]	1.464 ms (8.4%)
code_origins	17.802 ms [17.625 ms, 17.979 ms]	374.866 µs (2.2%)
iast	17.934 ms [17.754 ms, 18.114 ms]	506.989 µs (2.9%)
profiling	19.765 ms [19.563 ms, 19.966 ms]	2.338 ms (13.4%)
tracing	17.744 ms [17.569 ms, 17.919 ms]	317.204 µs (1.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	community-pr-10269
git_commit_date	1767720455	1767860050
git_commit_sha	`92c84e2`	`47d95f9`
release_version	1.59.0-SNAPSHOT~92c84e28db	1.59.0-SNAPSHOT~47d95f97ec

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1767862469	1767862469
ci_job_id	1335193688	1335193688
ci_pipeline_id	89620816	89620816
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-s72he4ik 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-s72he4ik 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	better [-1.366ms; -1.020ms] or [-36.639%; -27.352%]	2.536ms	3.729ms

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
appsec (14.621 s) : 14621000, 14621000
.   : milestone, 14621000,
iast (18.241 s) : 18241000, 18241000
.   : milestone, 18241000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
.   : milestone, 18073000,
profiling (14.96 s) : 14960000, 14960000
.   : milestone, 14960000,
tracing (14.479 s) : 14479000, 14479000
.   : milestone, 14479000,
section candidate
no_agent (15.046 s) : 15046000, 15046000
.   : milestone, 15046000,
appsec (14.496 s) : 14496000, 14496000
.   : milestone, 14496000,
iast (18.009 s) : 18009000, 18009000
.   : milestone, 18009000,
iast_GLOBAL (17.747 s) : 17747000, 17747000
.   : milestone, 17747000,
profiling (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
tracing (14.686 s) : 14686000, 14686000
.   : milestone, 14686000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.04 s [15.04 s, 15.04 s]	-
appsec	14.621 s [14.621 s, 14.621 s]	-419.0 ms (-2.8%)
iast	18.241 s [18.241 s, 18.241 s]	3.201 s (21.3%)
iast_GLOBAL	18.073 s [18.073 s, 18.073 s]	3.033 s (20.2%)
profiling	14.96 s [14.96 s, 14.96 s]	-80.0 ms (-0.5%)
tracing	14.479 s [14.479 s, 14.479 s]	-561.0 ms (-3.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.046 s [15.046 s, 15.046 s]	-
appsec	14.496 s [14.496 s, 14.496 s]	-550.0 ms (-3.7%)
iast	18.009 s [18.009 s, 18.009 s]	2.963 s (19.7%)
iast_GLOBAL	17.747 s [17.747 s, 17.747 s]	2.701 s (18.0%)
profiling	14.963 s [14.963 s, 14.963 s]	-83.0 ms (-0.6%)
tracing	14.686 s [14.686 s, 14.686 s]	-360.0 ms (-2.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~47d95f97ec, baseline=1.59.0-SNAPSHOT~92c84e28db
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.729 ms) : 3508, 3950
.   : milestone, 3729,
iast (2.21 ms) : 2146, 2274
.   : milestone, 2210,
iast_GLOBAL (2.259 ms) : 2194, 2323
.   : milestone, 2259,
profiling (2.072 ms) : 2020, 2125
.   : milestone, 2072,
tracing (2.049 ms) : 1998, 2100
.   : milestone, 2049,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (2.536 ms) : 2481, 2591
.   : milestone, 2536,
iast (2.22 ms) : 2155, 2285
.   : milestone, 2220,
iast_GLOBAL (2.257 ms) : 2191, 2322
.   : milestone, 2257,
profiling (2.094 ms) : 2040, 2149
.   : milestone, 2094,
tracing (2.044 ms) : 1993, 2096
.   : milestone, 2044,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	3.729 ms [3.508 ms, 3.95 ms]	2.254 ms (152.8%)
iast	2.21 ms [2.146 ms, 2.274 ms]	735.039 µs (49.8%)
iast_GLOBAL	2.259 ms [2.194 ms, 2.323 ms]	783.679 µs (53.1%)
profiling	2.072 ms [2.02 ms, 2.125 ms]	597.497 µs (40.5%)
tracing	2.049 ms [1.998 ms, 2.1 ms]	573.773 µs (38.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.471 ms, 1.494 ms]	-
appsec	2.536 ms [2.481 ms, 2.591 ms]	1.054 ms (71.1%)
iast	2.22 ms [2.155 ms, 2.285 ms]	737.904 µs (49.8%)
iast_GLOBAL	2.257 ms [2.191 ms, 2.322 ms]	774.321 µs (52.2%)
profiling	2.094 ms [2.04 ms, 2.149 ms]	612.204 µs (41.3%)
tracing	2.044 ms [1.993 ms, 2.096 ms]	562.187 µs (37.9%)

settings.gradle.kts

amarziali · 2026-01-07T12:29:51Z

...instrumentation/cics-9.1/src/main/java/datadog/trace/instrumentation/cics/CicsDecorator.java

+  }
+
+  @Override
+  protected String service() {


there is no need to override it since it's null on the base method

amarziali · 2026-01-07T12:31:21Z

...instrumentation/cics-9.1/src/main/java/datadog/trace/instrumentation/cics/CicsDecorator.java

+   */
+  public AgentSpan onLocalConnection(final AgentSpan span, final InetSocketAddress localAddr) {
+    if (localAddr != null && localAddr.getAddress() != null) {
+      span.setTag("network.local.address", localAddr.getAddress().getHostAddress());


thanks for having used otel attribute names

amarziali

Looks good. Thanks for that addition. I left few comments for improvement

amarziali · 2026-01-07T12:32:27Z

...instrumentation/cics-9.1/src/main/java/datadog/trace/instrumentation/cics/CicsDecorator.java

+    final String tranName = spec.getTranName();
+    final String tpnName = spec.getTPNName();
+
+    span.setResourceName(interactionVerb + " " + functionName);


as a future improvement this might be cached if the cardinality is not too high

So far, in my experience, the cardinality has 1 per service (with the note that we tend to do microservices).

amarziali · 2026-01-07T12:38:21Z

....1/src/main/java/datadog/trace/instrumentation/cics/JavaGatewayInterfaceInstrumentation.java

+      final int callDepth = CallDepthThreadLocalMap.getCallDepth(ECIInteraction.class);
+      if (callDepth > 0) {
+        // Inside execute() - add connection tags to the existing span instead of creating new one
+        final AgentSpan parentSpan = activeSpan();


This is a generally strong assumption. A way to make sure that the right span is always tracked is to use the context store here

ValentinZakharov

LGTM

…mentermodule

deejgregor · 2026-01-07T18:48:02Z

Heads-up: I noticed while testing that I'm not seeing the network.local.address and network.local.port tags for the local side of the connection. I'm looking into why.

I wouldn't suggest blocking/delaying the merge on this, but there's a chance I might have a tweak soon if I figure out what's going on.

amarziali · 2026-01-07T19:00:40Z

I wouldn't suggest blocking/delaying the merge on this, but there's a chance I might have a tweak soon if I figure out what's going on.

No worries just added a label to say that we could wait a bit still targeting next release if possible

mcculls requested review from a team as code owners January 7, 2026 10:42

mcculls added type: enhancement Enhancements and improvements inst: others All other instrumentations tag: community Community contribution labels Jan 7, 2026

mcculls requested a review from mhlidd January 7, 2026 10:42

mcculls added type: enhancement Enhancements and improvements inst: others All other instrumentations tag: community Community contribution labels Jan 7, 2026

mcculls temporarily deployed to ci-build January 7, 2026 10:42 — with GitHub Actions Inactive

amarziali reviewed Jan 7, 2026

View reviewed changes

settings.gradle.kts Outdated Show resolved Hide resolved

rename cics module to comply with naming conventions

d1d5b05

amarziali temporarily deployed to ci-build January 7, 2026 12:29 — with GitHub Actions Inactive

amarziali reviewed Jan 7, 2026

View reviewed changes

amarziali approved these changes Jan 7, 2026

View reviewed changes

mcculls mentioned this pull request Jan 7, 2026

Feature: CICS tracing #10269

Open

codenarc

65c1cb6

amarziali temporarily deployed to ci-build January 7, 2026 13:02 — with GitHub Actions Inactive

ValentinZakharov approved these changes Jan 7, 2026

View reviewed changes

amarziali temporarily deployed to ci-build January 7, 2026 15:38 — with GitHub Actions Inactive

Use WithTypeStructure to check structure constraints - move to instru…

d3372cd

…mentermodule

amarziali force-pushed the community-pr-10269 branch from bedb163 to d3372cd Compare January 7, 2026 15:39

amarziali temporarily deployed to ci-build January 7, 2026 15:56 — with GitHub Actions Inactive

amarziali added the tag: do not merge Do not merge changes label Jan 7, 2026

Fix forbiddenApi missing classes

47d95f9

amarziali temporarily deployed to ci-build January 8, 2026 08:14 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🪞 10269 - Feature: CICS tracing #10301

🪞 10269 - Feature: CICS tracing #10301

Uh oh!

mcculls commented Jan 7, 2026

Uh oh!

pr-commenter bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

amarziali Jan 7, 2026

Uh oh!

amarziali Jan 7, 2026

Uh oh!

amarziali left a comment

Uh oh!

amarziali Jan 7, 2026

Uh oh!

deejgregor Jan 7, 2026

Uh oh!

amarziali Jan 7, 2026

Uh oh!

ValentinZakharov left a comment

Uh oh!

deejgregor commented Jan 7, 2026

Uh oh!

amarziali commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

🪞 10269 - Feature: CICS tracing #10301

Are you sure you want to change the base?

🪞 10269 - Feature: CICS tracing #10301

Uh oh!

Conversation

mcculls commented Jan 7, 2026

Uh oh!

pr-commenter bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

amarziali Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

amarziali Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

amarziali Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

deejgregor Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

amarziali Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

ValentinZakharov left a comment

Choose a reason for hiding this comment

Uh oh!

deejgregor commented Jan 7, 2026

Uh oh!

amarziali commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pr-commenter bot commented Jan 7, 2026 •

edited

Loading