Skip to content

Mute JNA initialisation when creating ForeignMemoryWriters #10302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amarziali wants to merge 2 commits into from
Closed

Mute JNA initialisation when creating ForeignMemoryWriters #10302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873e9df
Mute JNA initialisation when creating ForeignMemoryWriters
amarziali Jan 7, 2026
fb3fbd7
move the blackhole closer to the init
amarziali Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...ooling/src/main/java/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriterJNA.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@
import com.sun.jna.Native;
import com.sun.jna.NativeLong;
import com.sun.jna.Pointer;
import datadog.trace.api.GlobalTracer;
import datadog.trace.api.Tracer;
import datadog.trace.context.TraceScope;

public final class MemFDUnixWriterJNA extends MemFDUnixWriter {
private final LibC libc = Native.load("c", LibC.class);
private final LibC libc;

private interface LibC extends Library {
long syscall(long number, Object... args);
Expand All @@ -17,6 +20,14 @@ private interface LibC extends Library {
int fcntl(int fd, int cmd, int arg);
}

public MemFDUnixWriterJNA() {
final Tracer tracer = GlobalTracer.get();
// JNA initialisation can do ldconfig and other commands. Those are hidden since internal.
try (TraceScope closeme = tracer != null ? tracer.muteTracing() : null) {
libc = Native.load("c", LibC.class);
}
}

@Override
protected long syscall(long number, String name, int flags) {
return libc.syscall(number, name, flags);
Expand Down
5 changes: 1 addition & 4 deletions dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,10 +919,7 @@ private CoreTracer(
() -> {
final ServiceDiscovery serviceDiscovery = serviceDiscoveryFactory.get();
if (serviceDiscovery != null) {
// JNA can do ldconfig and other commands. Those are hidden since internal.
try (final TraceScope blackhole = muteTracing()) {
serviceDiscovery.writeTracerMetadata(config);
}
serviceDiscovery.writeTracerMetadata(config);
}
},
1,
Expand Down
Loading